Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: net/proxy/proxy_resolver_v8_unittest.cc

Issue 2819011: TTF: Reenable some disabled tests. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_resolver_v8_unittest.cc
diff --git a/net/proxy/proxy_resolver_v8_unittest.cc b/net/proxy/proxy_resolver_v8_unittest.cc
index ac5ab713b813c744cb91cdfd0b6af06cc26280c1..b6d8a4758605c296872d68d652ccb8372064ac41 100644
--- a/net/proxy/proxy_resolver_v8_unittest.cc
+++ b/net/proxy/proxy_resolver_v8_unittest.cc
@@ -306,9 +306,9 @@ TEST(ProxyResolverV8Test, UnhandledException) {
EXPECT_EQ(3, bindings->errors_line_number[0]);
}
-// TODO(eroman): This test is disabed right now, since the parsing of
-// host/port doesn't check for non-ascii characters.
-TEST(ProxyResolverV8Test, DISABLED_ReturnUnicode) {
+// TODO(eroman): This test fails right now, since the parsing of
+// host/port doesn't check for non-ascii characters. http://crbug.com/46608
+TEST(ProxyResolverV8Test, FAILS_ReturnUnicode) {
ProxyResolverV8WithMockBindings resolver;
int result = resolver.SetPacScriptFromDisk("return_unicode.js");
EXPECT_EQ(OK, result);

Powered by Google App Engine
This is Rietveld 408576698