Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2818783003: Enable WebVR from WebappActivity (Closed)

Created:
3 years, 8 months ago by mthiesse
Modified:
3 years, 8 months ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable WebVR from WebappActivity This enabled WebVR from add-to-homescreen. BUG=701040 Review-Url: https://codereview.chromium.org/2818783003 Cr-Commit-Position: refs/heads/master@{#464611} Committed: https://chromium.googlesource.com/chromium/src/+/b37b6b2624f23823801ac0c8b1cfecde8ba1e31b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mthiesse
PTAL
3 years, 8 months ago (2017-04-13 22:34:29 UTC) #2
bshe
lgtm
3 years, 8 months ago (2017-04-13 22:56:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818783003/1
3 years, 8 months ago (2017-04-13 23:05:43 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 23:44:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b37b6b2624f23823801ac0c8b1cf...

Powered by Google App Engine
This is Rietveld 408576698