[Offline pages]: Implement background loader to save on last retry, and record last retry success U…

chrome/browser/android/offline_pages/prerendering_offliner.cc

Index: chrome/browser/android/offline_pages/prerendering_offliner.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc
index db341ef4c87b63951480215df3ff2f69ab5334b3..80971e73476534cd3cfd5c6e2111c1958efac173 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc
@@ -158,12 +158,16 @@ void PrerenderingOffliner::OnSavePageDone(
   // Determine status and run the completion callback.
   Offliner::RequestStatus save_status;
   if (save_result == SavePageResult::SUCCESS) {
-    save_status = RequestStatus::SAVED;
+    if (saved_on_last_retry_)

[Pete Williamson, 2017/04/13 22:57:15]

Should we clear this in the ctor just for completeness?

[fgorski, 2017/04/14 05:15:57]

If by clear you mean initialize: +1
... And Cathy knows how much debugging that takes to find.

[chili, 2017/04/15 00:34:59]

Done.
This actually caused a test failure T___T

+      save_status = RequestStatus::SAVED_ON_LAST_RETRY;
+    else
+      save_status = RequestStatus::SAVED;
   } else {
     // TODO(dougarnett): Consider reflecting some recommendation to retry the
     // request based on specific save error cases.
     save_status = RequestStatus::SAVE_FAILED;
   }
+  saved_on_last_retry_ = false;
   completion_callback_.Run(request, save_status);
 }
 
@@ -268,6 +272,7 @@ bool PrerenderingOffliner::HandleTimeout(const SavePageRequest& request) {
         (request.started_attempt_count() + 1 >= policy_->GetMaxStartedTries() ||
          request.completed_attempt_count() + 1 >=
              policy_->GetMaxCompletedTries())) {
+      saved_on_last_retry_ = true;
       GetOrCreateLoader()->StartSnapshot();
       return true;
     }