chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc - Issue 2818783002: [Offline pages]: Implement background loader to save on last retry, and record last retry success U…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Issue 2818783002: [Offline pages]: Implement background loader to save on last retry, and record last retry success U… (Closed)

Patch Set: request coordinator update Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/prerendering_offliner.cc ('K') | « chrome/browser/android/offline_pages/prerendering_offliner.cc ('k') | components/offline_pages/core/background/offliner.h » ('j') | components/offline_pages/core/background/request_coordinator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

diff --git a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

index d338b3c03176ebd38f12b7d3582b71c3f9cdb24d..de8db1794490a4302876595fc6d601525a677f75 100644

--- a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

+++ b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

@@ -472,6 +472,11 @@ TEST_F(PrerenderingOfflinerTest, HandleTimeoutWithLowbarAndCompletedTriesMet) {

loader()->set_is_lowbar_met(true);

EXPECT_TRUE(offliner()->HandleTimeout(request));

EXPECT_TRUE(loader()->start_snapshot_called());

+ EXPECT_TRUE(SaveInProgress());

+ model()->CompleteSavingAsSuccess();

+ PumpLoop();

+ EXPECT_TRUE(completion_callback_called());

+ EXPECT_EQ(Offliner::RequestStatus::SAVED_ON_LAST_RETRY, request_status());

}

TEST_F(PrerenderingOfflinerTest,