Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2818773002: Fix GCC builds after 204989a5a / r44650 (Closed)

Created:
3 years, 8 months ago by Jakob Kummerow
Modified:
3 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Fix GCC builds after 204989a5a / r44650 TBR=ishell@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2818773002 Cr-Commit-Position: refs/heads/master@{#44651} Committed: https://chromium.googlesource.com/v8/v8/+/6e0f52e1a8d8a205e6e69274f5288b87f30f9550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/objects.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Jakob Kummerow
Apparently GCC doesn't like "uint8_t* one_byte_content_ = nullptr;", the pointer contains bogus data when "delete[]" ...
3 years, 8 months ago (2017-04-13 15:19:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818773002/1
3 years, 8 months ago (2017-04-13 15:19:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/6e0f52e1a8d8a205e6e69274f5288b87f30f9550
3 years, 8 months ago (2017-04-13 15:21:56 UTC) #6
Igor Sheludko
3 years, 8 months ago (2017-04-18 09:01:46 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698