FocusableBorder/fractional scales: snap to different pixel

FocusableBorder/fractional scales: snap to different pixel

A view can have a fractional pixel size. The pixel size of the canvas we
draw to can get rounded down instead of up. By using
gfx::ScaleToEnclosedRect instead of gfx::ScaleToEnclosingRect we'll
be sure to draw within the canvas's bounds.

The linked bug also exhibited itself in the bookmark bubble's inputs at
various scale factors --- 1.75, for example.

BUG=696434
Review-Url: https://codereview.chromium.org/2818713006
Cr-Commit-Position: refs/heads/master@{#465080}
Committed: https://chromium.googlesource.com/chromium/src/+/bc1501887b1ed2b82fc04b01d94ca44fc9fbc1d9

[Evan Stade, 2017-04-14 18:56:11]

estade@chromium.org changed reviewers:
+ bsep@chromium.org, tapted@chromium.org

[Bret, 2017-04-14 19:02:08]

LGTM. This might explain some artifacts I've seen floating around...

[tapted, 2017-04-17 23:41:09]

very neat! lgtm

(and sorry for the delay - long weekend)

[Evan Stade, 2017-04-17 23:43:38]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-04-17 23:44:04]

On 2017/04/17 23:41:09, tapted wrote:
> very neat! lgtm
> 
> (and sorry for the delay - long weekend)

not a problem. Thanks.

[commit-bot: I haz the power, 2017-04-17 23:44:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 00:38:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492472618006660, "parent_rev":
"ae91e9c848e802335b5c424e62346b950b49cf31", "commit_rev":
"bc1501887b1ed2b82fc04b01d94ca44fc9fbc1d9"}

[commit-bot: I haz the power, 2017-04-18 00:38:45]

Description was changed from

==========
FocusableBorder/fractional scales: snap to different pixel

A view can have a fractional pixel size. The pixel size of the canvas we
draw to can get rounded down instead of up. By using
gfx::ScaleToEnclosedRect instead of gfx::ScaleToEnclosingRect we'll
be sure to draw within the canvas's bounds.

The linked bug also exhibited itself in the bookmark bubble's inputs at
various scale factors --- 1.75, for example.

BUG=696434
==========

to

==========
FocusableBorder/fractional scales: snap to different pixel

A view can have a fractional pixel size. The pixel size of the canvas we
draw to can get rounded down instead of up. By using
gfx::ScaleToEnclosedRect instead of gfx::ScaleToEnclosingRect we'll
be sure to draw within the canvas's bounds.

The linked bug also exhibited itself in the bookmark bubble's inputs at
various scale factors --- 1.75, for example.

BUG=696434

Review-Url: https://codereview.chromium.org/2818713006
Cr-Commit-Position: refs/heads/master@{#465080}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc1501887b1ed2b82fc04b01d94c...
==========

[commit-bot: I haz the power, 2017-04-18 00:38:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc1501887b1ed2b82fc04b01d94c...