Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2818713004: Remove unnecessary include in content/test/test_blink_web_unit_test_support.cc. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary include in content/test/test_blink_web_unit_test_support.cc. Asides from the slight increase in compilation time, the include gives the wrong impression that the file depends on a low-level SQLite integration detail. BUG=653751 Review-Url: https://codereview.chromium.org/2818713004 Cr-Commit-Position: refs/heads/master@{#464684} Committed: https://chromium.googlesource.com/chromium/src/+/ef6d19700c2ea1b349d2b9ffcf20a488cef00fa9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
pwnall
PTAL?
3 years, 8 months ago (2017-04-13 22:43:39 UTC) #3
kinuko
lgtm
3 years, 8 months ago (2017-04-14 05:39:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818713004/1
3 years, 8 months ago (2017-04-14 05:40:06 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 06:03:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef6d19700c2ea1b349d2b9ffcf20...

Powered by Google App Engine
This is Rietveld 408576698