Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6457)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ArrowBubbleDrawable.java

Issue 2818693002: Improve (ViewAnchored)TextBubble logic (Closed)
Patch Set: Addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ArrowBubbleDrawable.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ArrowBubbleDrawable.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ArrowBubbleDrawable.java
index 49f50d0e29303181ac7291d8e9caca9e1a9d9c44..3bef42422b5b0a6d33c6cd0d1ee7fae574fa5db8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ArrowBubbleDrawable.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ArrowBubbleDrawable.java
@@ -22,7 +22,7 @@ import org.chromium.chrome.R;
/**
* A {@link Drawable} that is a bubble with an arrow pointing out of either the top or bottom.
*/
-class ArrowBubbleDrawable extends Drawable {
+class ArrowBubbleDrawable extends Drawable implements Drawable.Callback {
private final Rect mCachedBubblePadding = new Rect();
private final int mRadiusPx;
@@ -40,6 +40,9 @@ class ArrowBubbleDrawable extends Drawable {
null, null));
mArrowDrawable = (BitmapDrawable) ApiCompatibilityUtils.getDrawable(
context.getResources(), R.drawable.bubble_point_white);
+
+ mBubbleDrawable.setCallback(this);
+ mArrowDrawable.setCallback(this);
}
/**
@@ -72,6 +75,13 @@ class ArrowBubbleDrawable extends Drawable {
}
/**
+ * @return Whether or not the arrow is currently drawing on top of this {@link Drawable}.
+ */
+ public boolean isArrowOnTop() {
+ return mArrowOnTop;
+ }
+
+ /**
* @param color The color to make the bubble and arrow.
*/
public void setBubbleColor(@ColorInt int color) {
@@ -80,6 +90,22 @@ class ArrowBubbleDrawable extends Drawable {
invalidateSelf();
}
+ // Drawable.Callback implementation.
+ @Override
+ public void invalidateDrawable(Drawable who) {
+ invalidateSelf();
+ }
+
+ @Override
+ public void scheduleDrawable(Drawable who, Runnable what, long when) {
+ scheduleSelf(what, when);
+ }
+
+ @Override
+ public void unscheduleDrawable(Drawable who, Runnable what) {
+ unscheduleSelf(what);
+ }
+
// Drawable implementation.
@Override
public void draw(Canvas canvas) {

Powered by Google App Engine
This is Rietveld 408576698