chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java - Issue 2818693002: Improve (ViewAnchored)TextBubble logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Issue 2818693002: Improve (ViewAnchored)TextBubble logic (Closed)

Patch Set: Addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

index f49b9d20ebc3a6f984c761d7007b66d941af54f0..8d20e16cd3a687f1e36145b7347cdaf85e98bc57 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

@@ -2259,7 +2259,7 @@ public class ToolbarPhone extends ToolbarLayout

TabSwitcherCallout.showIfNecessary(getContext(), mToggleTabStackButton);

if (mTabSwitcherCallout == null) return;

- mTabSwitcherCallout.setOnDismissListener(new OnDismissListener() {

+ mTabSwitcherCallout.addOnDismissListener(new OnDismissListener() {

@Override

public void onDismiss() {

if (mControlsVisibilityDelegate != null) {

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ArrowBubbleDrawable.java » ('j') | no next file with comments »