Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2818673004: Rename filenames that end with libarchive with minizip. (Closed)

Created:
3 years, 8 months ago by takise
Modified:
3 years, 8 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename filenames that end with libarchive with minizip. BUG=607078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2818673004 Cr-Commit-Position: refs/heads/master@{#464679} Committed: https://chromium.googlesource.com/chromium/src/+/4ae5d2b150e634cac3f852678d3e613ee12fa007

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1047 lines) Patch
M ui/file_manager/zip_archiver/cpp/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/zip_archiver/cpp/compressor.cc View 1 chunk +1 line, -1 line 1 comment Download
D ui/file_manager/zip_archiver/cpp/compressor_archive_libarchive.h View 1 chunk +0 lines, -93 lines 0 comments Download
D ui/file_manager/zip_archiver/cpp/compressor_archive_libarchive.cc View 1 chunk +0 lines, -243 lines 0 comments Download
A + ui/file_manager/zip_archiver/cpp/compressor_archive_minizip.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/zip_archiver/cpp/compressor_archive_minizip.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/zip_archiver/cpp/volume.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/file_manager/zip_archiver/cpp/volume_archive_libarchive.h View 1 chunk +0 lines, -208 lines 0 comments Download
D ui/file_manager/zip_archiver/cpp/volume_archive_libarchive.cc View 1 chunk +0 lines, -497 lines 0 comments Download
A + ui/file_manager/zip_archiver/cpp/volume_archive_minizip.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/zip_archiver/cpp/volume_archive_minizip.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
takise
PTAL. Thanks!
3 years, 8 months ago (2017-04-14 04:26:46 UTC) #7
mtomasz
lgtm https://codereview.chromium.org/2818673004/diff/1/ui/file_manager/zip_archiver/cpp/compressor.cc File ui/file_manager/zip_archiver/cpp/compressor.cc (right): https://codereview.chromium.org/2818673004/diff/1/ui/file_manager/zip_archiver/cpp/compressor.cc#newcode1 ui/file_manager/zip_archiver/cpp/compressor.cc:1: // Copyright 2017 The Chromium OS Authors. All ...
3 years, 8 months ago (2017-04-14 04:40:08 UTC) #8
takise
On 2017/04/14 04:40:08, mtomasz wrote: > lgtm > > https://codereview.chromium.org/2818673004/diff/1/ui/file_manager/zip_archiver/cpp/compressor.cc > File ui/file_manager/zip_archiver/cpp/compressor.cc (right): > ...
3 years, 8 months ago (2017-04-14 04:42:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818673004/1
3 years, 8 months ago (2017-04-14 04:42:27 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 04:49:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ae5d2b150e634cac3f852678d3e...

Powered by Google App Engine
This is Rietveld 408576698