[DeviceService] Expose battery monitoring solely via the Device Service

[DeviceService] Expose battery monitoring solely via the Device Service

This CL makes battery impl be completely only part of the implementation
of the Device Service.
  - Moves //device/battery to //services/device/battery
  - Makes //services/device/battery visible in GN only to
    //services/device

BUG=684422
TBR=stevenjb@chromium.org, tsepez@chromium.org, boliu@chromium.org

Review-Url: https://codereview.chromium.org/2818673003
Cr-Commit-Position: refs/heads/master@{#468899}
Committed: https://chromium.googlesource.com/chromium/src/+/cb374e8d7a568886dd2bbf469c67f91de19fa4f3

[leonhsl(Using Gerrit), 2017-04-13 05:31:21]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 05:32:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-13 05:42:05]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 05:42:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-13 05:42:31]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-13 06:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 06:40:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2017-04-14 02:59:40]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 03:00:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 03:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 03:59:58]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-04-17 01:26:01]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 01:26:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 03:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 03:05:54]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-04-17 05:36:10]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 05:36:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-17 05:38:20]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-04-17 07:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 07:16:13]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-04-17 08:09:00]

leon.han@intel.com changed reviewers:
+ blundell@chromium.org, rockot@google.com

[leonhsl(Using Gerrit), 2017-04-17 08:09:01]

PTAL, Thanks.

[leonhsl(Using Gerrit), 2017-04-17 23:50:43]

leon.han@intel.com changed reviewers:
+ rockot@chromium.org
- rockot@google.com

[blundell, 2017-04-18 13:36:08]

lgtm, thanks!

[leonhsl(Using Gerrit), 2017-04-19 03:31:52]

leon.han@intel.com changed reviewers:
+ timvolodine@chromium.org

[leonhsl(Using Gerrit), 2017-04-19 03:31:53]

+Tim for battery OWNER review, Thanks!

[leonhsl(Using Gerrit), 2017-04-25 02:53:50]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 02:54:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 04:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 04:35:53]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-04-25 06:56:41]

Friendly ping Tim~
Uploaded ps#3 to rebase onto ToT, PTAL, Thanks!

[blundell, 2017-05-02 08:44:38]

Hey Tim,

Friendly ping!

Thanks,

Colin

[timvolodine, 2017-05-02 18:19:05]

Apologies for the delay, must have missed it somehow..

Looking fine to me overall so lgtm % some comments below
thanks!

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
File services/device/battery/BUILD.gn (left):

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
services/device/battery/BUILD.gn:30: defines = [ "DEVICE_BATTERY_IMPLEMENTATION"
]
I assume this has no impact anymore? i.e. DEVICE_BATTERY_IMPLEMENTATION removed
at some stage?

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
File
services/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
(right):

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
services/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:79:
? new AndroidBatteryManagerWrapper((
"(" is very weird, can you put it so it's clear it's a cast?

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
File services/device/battery/battery_status_manager_win.h (left):

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
services/device/battery/battery_status_manager_win.h:21: DEVICE_BATTERY_EXPORT
mojom::BatteryStatus ComputeWebBatteryStatus(
is the DEVICE_BATTERY_EXPORT not needed anymore?

[leonhsl(Using Gerrit), 2017-05-03 01:59:21]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 01:59:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-05-03 02:27:17]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 02:27:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-05-03 03:07:02]

Thanks Tim a lot for review! Uploaded ps#5 to address comments.

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
File services/device/battery/BUILD.gn (left):

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
services/device/battery/BUILD.gn:30: defines = [ "DEVICE_BATTERY_IMPLEMENTATION"
]
On 2017/05/02 18:19:04, timvolodine wrote:
> I assume this has no impact anymore? i.e. DEVICE_BATTERY_IMPLEMENTATION
removed
> at some stage?

Yeah this macro was for identifying DEVICE_BATTERY_EXPORT's value as 'export' or
'import' in case of component build, but now we're moving all battery codes to
be hidden inside Device Service and want to change the battery target from
'component' to 'source_set', so we remove both DEVICE_BATTERY_IMPLEMENTATION and
DEVICE_BATTERY_EXPORT.

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
File
services/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java
(right):

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
services/device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java:79:
? new AndroidBatteryManagerWrapper((
On 2017/05/02 18:19:04, timvolodine wrote:
> "(" is very weird, can you put it so it's clear it's a cast?

Done. We did not change here, it's caused by 'git cl format'..

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
File services/device/battery/battery_status_manager_win.h (left):

https://codereview.chromium.org/2818673003/diff/80001/services/device/battery...
services/device/battery/battery_status_manager_win.h:21: DEVICE_BATTERY_EXPORT
mojom::BatteryStatus ComputeWebBatteryStatus(
On 2017/05/02 18:19:04, timvolodine wrote:
> is the DEVICE_BATTERY_EXPORT not needed anymore?

Yeah, it's only for component build and now battery target is not a component
but just a source_set.

[leonhsl(Using Gerrit), 2017-05-03 03:15:11]

leon.han@intel.com changed reviewers:
+ boliu@chromium.org, stevenjb@chromium.org, tsepez@chromium.org

[leonhsl(Using Gerrit), 2017-05-03 03:15:12]

Let me TBR OWNERs for trivial changes:
  tsepez@:    mechanical movement of battery_monitor.mojom and
battery_status.mojom
  stevenjb@:  "+chromeos/dbus" added in services/device/battery/DEPS
  boliu@:     android_webview/native/BUILD.gn

Thanks all!

[leonhsl(Using Gerrit), 2017-05-03 03:18:39]

Description was changed from

==========
[DeviceService] Expose battery monitoring solely via the Device Service

This CL makes battery impl be completely only part of the implementation
of the Device Service.
  - Moves //device/battery to //services/device/battery
  - Makes //services/device/battery visible in GN only to
    //services/device

BUG=684422
==========

to

==========
[DeviceService] Expose battery monitoring solely via the Device Service

This CL makes battery impl be completely only part of the implementation
of the Device Service.
  - Moves //device/battery to //services/device/battery
  - Makes //services/device/battery visible in GN only to
    //services/device

BUG=684422
TBR=stevenjb@chromium.org, tsepez@chromium.org, boliu@chromium.org
==========

[commit-bot: I haz the power, 2017-05-03 04:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 04:43:34]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-05-03 05:16:18]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2017-05-03 05:16:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
blundell@chromium.org, timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2818673003/#ps120001
(title: "Java file format change")

[commit-bot: I haz the power, 2017-05-03 05:16:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 05:22:27]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1493788578960720,
"parent_rev": "abed2a56f122e7d6ca95e37a42c0c14b73a85a35", "commit_rev":
"cb374e8d7a568886dd2bbf469c67f91de19fa4f3"}

[commit-bot: I haz the power, 2017-05-03 05:22:51]

Description was changed from

==========
[DeviceService] Expose battery monitoring solely via the Device Service

This CL makes battery impl be completely only part of the implementation
of the Device Service.
  - Moves //device/battery to //services/device/battery
  - Makes //services/device/battery visible in GN only to
    //services/device

BUG=684422
TBR=stevenjb@chromium.org, tsepez@chromium.org, boliu@chromium.org
==========

to

==========
[DeviceService] Expose battery monitoring solely via the Device Service

This CL makes battery impl be completely only part of the implementation
of the Device Service.
  - Moves //device/battery to //services/device/battery
  - Makes //services/device/battery visible in GN only to
    //services/device

BUG=684422
TBR=stevenjb@chromium.org, tsepez@chromium.org, boliu@chromium.org

Review-Url: https://codereview.chromium.org/2818673003
Cr-Commit-Position: refs/heads/master@{#468899}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb374e8d7a568886dd2bbf469c67...
==========

[commit-bot: I haz the power, 2017-05-03 05:22:53]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/cb374e8d7a568886dd2bbf469c67...