Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2818663002: Prevent extension webview tests from being broken by data URL deprecation (Closed)

Created:
3 years, 8 months ago by meacer
Modified:
3 years, 8 months ago
Reviewers:
wjmaclean
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent extension webview tests from being broken by data URL deprecation Content-initiated main-frame navigations to data URLs are being blocked in crbug.com/594215. This CL changes several tests that use data URLs. BUG=594215 Review-Url: https://codereview.chromium.org/2818663002 Cr-Commit-Position: refs/heads/master@{#464516} Committed: https://chromium.googlesource.com/chromium/src/+/4ed27b3319ee736bef367e0657e0797685e92c43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/test/data/extensions/platform_apps/web_view/shim/guest.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/guest_noreferrer.html View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/test/data/web_view/apitest/guest.html View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/test/data/web_view/apitest/guest_noreferrer.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
meacer
wjmaclean@: Can you please take a look? Thanks!
3 years, 8 months ago (2017-04-13 18:12:04 UTC) #8
wjmaclean
On 2017/04/13 18:12:04, Mustafa Emre Acer wrote: > wjmaclean@: Can you please take a look? ...
3 years, 8 months ago (2017-04-13 18:14:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818663002/1
3 years, 8 months ago (2017-04-13 18:16:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/362122)
3 years, 8 months ago (2017-04-13 19:18:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818663002/1
3 years, 8 months ago (2017-04-13 19:23:28 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 19:57:48 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ed27b3319ee736bef367e0657e0...

Powered by Google App Engine
This is Rietveld 408576698