Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2818653003: Don't double-JSON-escape crash stacks in asan symbolizer. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't double-JSON-escape crash stacks in asan symbolizer. gtest_utils.py used to double-unescape test JSON. Now that that's fixed, there's no need to escape twice here. BUG=632047 Review-Url: https://codereview.chromium.org/2818653003 Cr-Commit-Position: refs/heads/master@{#464511} Committed: https://chromium.googlesource.com/chromium/src/+/3abe8396ac16185a59b420564d80c1f802ce1f3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -27 lines) Patch
M tools/valgrind/asan/asan_symbolize.py View 2 chunks +1 line, -27 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nico
3 years, 8 months ago (2017-04-13 16:42:05 UTC) #2
Vadim Sh.
lgtm
3 years, 8 months ago (2017-04-13 19:20:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818653003/1
3 years, 8 months ago (2017-04-13 19:37:55 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 19:46:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3abe8396ac16185a59b420564d80...

Powered by Google App Engine
This is Rietveld 408576698