Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2818623004:
Use MADV_FREE_REUSABLE instead of MADV_FREE in partition alloc for macOS. (Closed)
|
Created:
3 years, 8 months ago by erikchen Modified:
3 years, 8 months ago CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), Mads Ager (chromium), vmpstr+watch_chromium.org, wfh+watch_chromium.org, oilpan-reviews, danakj+watch_chromium.org, kouhei+heap_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse MADV_FREE_REUSABLE instead of MADV_FREE in partition alloc for macOS.
MADV_FREE_REUSABLE has comparable behavior, but also marks the pages with the
reusable bit, which allows both Activity Monitor and memory-infra to correctly
track the pages.
BUG=708797
Review-Url: https://codereview.chromium.org/2818623004
Cr-Commit-Position: refs/heads/master@{#465910}
Committed: https://chromium.googlesource.com/chromium/src/+/170a64cd3c62e469dce0fd4790843e414ea8e5ef
Patch Set 1 #Patch Set 2 : Add comments #Messages
Total messages: 24 (15 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Test CL that changes MADV_FREE to MADV_FREE_REUSABLE on macOS. BUG= ========== to ========== Use MADV_FREE_REUSABLE instead of MADV_FREE in partition alloc for macOS. MADV_FREE_REUSABLE has comparable behavior, but also marks the pages with the reusable bit, which allows both Activity Monitor and memory-infra to correctly track the pages. BUG=708797 ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
erikchen@chromium.org changed reviewers: + haraken@chromium.org, mark@chromium.org
haraken, mark: Please review. PS#1 passes all tests, and PS#2 just adds a comment.
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sigbjornf@opera.com changed reviewers: + sigbjornf@opera.com
Is it available across all supported OSX versions?
On 2017/04/20 05:45:40, sof wrote: > Is it available across all supported OSX versions? Yes, it's available in 10_9_0, the earliest macOS version supported by Chrome.
Description was changed from ========== Use MADV_FREE_REUSABLE instead of MADV_FREE in partition alloc for macOS. MADV_FREE_REUSABLE has comparable behavior, but also marks the pages with the reusable bit, which allows both Activity Monitor and memory-infra to correctly track the pages. BUG=708797 ========== to ========== Use MADV_FREE_REUSABLE instead of MADV_FREE in partition alloc for macOS. MADV_FREE_REUSABLE has comparable behavior, but also marks the pages with the reusable bit, which allows both Activity Monitor and memory-infra to correctly track the pages. BUG=708797 ==========
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
I can't see the associated bug, but issue 675956 is another which I suspect is due to madvise() lag.
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492667948339460,
"parent_rev": "1ac68cf90fa046d3e9c1418aee7cd14b8ec38210", "commit_rev":
"170a64cd3c62e469dce0fd4790843e414ea8e5ef"}
Message was sent while issue was closed.
Description was changed from ========== Use MADV_FREE_REUSABLE instead of MADV_FREE in partition alloc for macOS. MADV_FREE_REUSABLE has comparable behavior, but also marks the pages with the reusable bit, which allows both Activity Monitor and memory-infra to correctly track the pages. BUG=708797 ========== to ========== Use MADV_FREE_REUSABLE instead of MADV_FREE in partition alloc for macOS. MADV_FREE_REUSABLE has comparable behavior, but also marks the pages with the reusable bit, which allows both Activity Monitor and memory-infra to correctly track the pages. BUG=708797 Review-Url: https://codereview.chromium.org/2818623004 Cr-Commit-Position: refs/heads/master@{#465910} Committed: https://chromium.googlesource.com/chromium/src/+/170a64cd3c62e469dce0fd479084... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/170a64cd3c62e469dce0fd479084...
Message was sent while issue was closed.
LGTM |
