Mac: Fix crash in CreateSecCertificateArrayForX509Certificate.

Mac: Fix crash in CreateSecCertificateArrayForX509Certificate.

One of the calls to CreateSecCertificateFromBytes wasn't checking the return value.

BUG=671420, 711077
Review-Url: https://codereview.chromium.org/2818573004
Cr-Commit-Position: refs/heads/master@{#464771}
Committed: https://chromium.googlesource.com/chromium/src/+/22447b66eb8bb0a9b174c963a1a387f7de1182b7

[mattm, 2017-04-13 00:18:20]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[mattm, 2017-04-13 00:19:15]

mattm@chromium.org changed reviewers:
+ eroman@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:19:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-13 00:39:49]

Description was changed from

==========
Mac: Fix crash in CreateSecCertificateArrayForX509Certificate.

One of the calls to CreateSecCertificateFromBytes wasn't checking the return
value.

BUG=671420
==========

to

==========
Mac: Fix crash in CreateSecCertificateArrayForX509Certificate.

One of the calls to CreateSecCertificateFromBytes wasn't checking the return
value.

BUG=671420,711077
==========

[commit-bot: I haz the power, 2017-04-13 00:43:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:43:06]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-04-14 18:45:26]

rch@chromium.org changed reviewers:
+ rch@chromium.org

[Ryan Hamilton, 2017-04-14 18:45:27]

lgtm  any chance writing a regression test is easy?

[mattm, 2017-04-14 18:46:19]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-04-14 18:46:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-14 18:48:20]

On 2017/04/14 18:45:27, Ryan Hamilton wrote:
> lgtm  any chance writing a regression test is easy?

Thanks!
Should be possible. I think we may already have a test for the main server cert,
but not for intermediates. I'll look into that separately.

[commit-bot: I haz the power, 2017-04-14 19:15:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492195579094400, "parent_rev":
"c8152899d3cd6c3f92446bf75bc63ce606a82bde", "commit_rev":
"22447b66eb8bb0a9b174c963a1a387f7de1182b7"}

[commit-bot: I haz the power, 2017-04-14 19:16:02]

Description was changed from

==========
Mac: Fix crash in CreateSecCertificateArrayForX509Certificate.

One of the calls to CreateSecCertificateFromBytes wasn't checking the return
value.

BUG=671420,711077
==========

to

==========
Mac: Fix crash in CreateSecCertificateArrayForX509Certificate.

One of the calls to CreateSecCertificateFromBytes wasn't checking the return
value.

BUG=671420,711077

Review-Url: https://codereview.chromium.org/2818573004
Cr-Commit-Position: refs/heads/master@{#464771}
Committed:
https://chromium.googlesource.com/chromium/src/+/22447b66eb8bb0a9b174c963a1a3...
==========

[commit-bot: I haz the power, 2017-04-14 19:16:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/22447b66eb8bb0a9b174c963a1a3...

[eroman, 2017-04-14 19:29:22]

lgtm