Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2818573002: Add Toolbar test utility classes. (Closed)

Created:
3 years, 8 months ago by lpromero
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Toolbar test utility classes. BUG=none R=sczs@chromium.org,marq@chromium.org Review-Url: https://codereview.chromium.org/2818573002 Cr-Commit-Position: refs/heads/master@{#464444} Committed: https://chromium.googlesource.com/chromium/src/+/c08796e46810403645b6cf2cc4f8890c78a361de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -37 lines) Patch
M ios/chrome/browser/ui/toolbar/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios_unittest.mm View 2 chunks +1 line, -37 lines 0 comments Download
A ios/shared/chrome/browser/ui/toolbar/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/shared/chrome/browser/ui/toolbar/toolbar_test_util.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/shared/chrome/browser/ui/toolbar/toolbar_test_util.mm View 1 chunk +38 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
lpromero
3 years, 8 months ago (2017-04-12 21:19:30 UTC) #1
sczs
lgtm
3 years, 8 months ago (2017-04-12 23:14:48 UTC) #6
lpromero
+marq for OWNERS review.
3 years, 8 months ago (2017-04-13 13:10:36 UTC) #7
marq (ping after 24h)
lgtm
3 years, 8 months ago (2017-04-13 15:01:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818573002/1
3 years, 8 months ago (2017-04-13 16:48:27 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 16:55:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c08796e46810403645b6cf2cc4f8...

Powered by Google App Engine
This is Rietveld 408576698