Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2818563005: [test] Fix presubmit for new dependency (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
Reviewers:
martyn.capewell
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix presubmit for new dependency TBR=martyn.capewell@arm.com NOTRY=true Review-Url: https://codereview.chromium.org/2818563005 Cr-Commit-Position: refs/heads/master@{#44654} Committed: https://chromium.googlesource.com/v8/v8/+/e8cfc5b7ca2f27a0805bb92dfbae0cd5ae03d472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/presubmit.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
TBR. Right now the continuous presubmit bot dives into the new deps folder.
3 years, 8 months ago (2017-04-13 19:48:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818563005/1
3 years, 8 months ago (2017-04-13 19:49:16 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 19:50:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e8cfc5b7ca2f27a0805bb92dfbae0cd5ae0...

Powered by Google App Engine
This is Rietveld 408576698