sendBeacon should throw a TypeError on bad URLs.

sendBeacon should throw a TypeError on bad URLs.

sendBeacon should throw a TypeError on bad URLs
instead of syntax error.

Bug=660241
Review-Url: https://codereview.chromium.org/2818563004
Cr-Commit-Position: refs/heads/master@{#465183}
Committed: https://chromium.googlesource.com/chromium/src/+/0cfcab89310f8e7ad6db537c686200c0f545b613

[nikhil.sahni, 2017-04-13 11:27:49]

Description was changed from

==========
sendBeacon should throw a TypeError on bad URLs.

sendBeacon should throw a TypeError on bad URLs
instead of syntax error.

Bug=660241

BUG=
==========

to

==========
sendBeacon should throw a TypeError on bad URLs.

sendBeacon should throw a TypeError on bad URLs
instead of syntax error.

Bug=660241

R=SamsungPeerReview
==========

[nikhil.sahni, 2017-04-13 11:27:49]

nikhil.sahni@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Srirama, 2017-04-13 11:36:28]

Peer review looks good.

[nikhil.sahni, 2017-04-13 11:40:41]

Description was changed from

==========
sendBeacon should throw a TypeError on bad URLs.

sendBeacon should throw a TypeError on bad URLs
instead of syntax error.

Bug=660241

R=SamsungPeerReview
==========

to

==========
sendBeacon should throw a TypeError on bad URLs.

sendBeacon should throw a TypeError on bad URLs
instead of syntax error.

Bug=660241
==========

[nikhil.sahni, 2017-04-13 11:40:41]

nikhil.sahni@samsung.com changed reviewers:
+ igrigorik@chromium.org, tyoshino@chromium.org, yhirano@chromium.org

[tyoshino (SeeGerritForStatus), 2017-04-14 04:30:03]

Code looks good. Could you please add a layout test?

[nikhil.sahni, 2017-04-17 03:56:27]

On 2017/04/14 04:30:03, tyoshino wrote:
> Code looks good. Could you please add a layout test?

yes sure I will add that.

[nikhil.sahni, 2017-04-17 03:56:30]

On 2017/04/14 04:30:03, tyoshino wrote:
> Code looks good. Could you please add a layout test?

yes sure I will add that.

[tyoshino (SeeGerritForStatus), 2017-04-17 04:12:53]

On 2017/04/17 03:56:30, nikhil.sahni wrote:
> On 2017/04/14 04:30:03, tyoshino wrote:
> > Code looks good. Could you please add a layout test?
> 
> yes sure I will add that.

Great. Please ping when ready.

[nikhil.sahni, 2017-04-17 15:02:41]

The CQ bit was checked by nikhil.sahni@samsung.com

[commit-bot: I haz the power, 2017-04-17 15:02:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 15:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 15:02:54]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[nikhil.sahni, 2017-04-17 15:07:05]

The CQ bit was checked by nikhil.sahni@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 15:07:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 15:07:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 15:07:15]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[nikhil.sahni, 2017-04-17 15:28:44]

Hi Tyoshino,

I found a file beacon-basic-expected.txt, which tests the sendBeacon function on
bad URL's in beacon-basic.html

I think Changing these 2 lines from SyntaxError to TypeError will be fine I
guess for LayoutTests. 

Plz let me know if this is fine ? then I'll push the changes.

PASS navigator.sendBeacon('http:') threw exception SyntaxError: Failed to
execute 'sendBeacon' on 'Navigator': The URL argument is ill-formed or
unsupported..
PASS navigator.sendBeacon('javascript:alert(1);') threw exception SyntaxError:
Failed to execute 'sendBeacon' on 'Navigator': Beacons are only supported over
HTTP(S)..

[Srirama, 2017-04-18 04:19:54]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 04:20:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2017-04-18 04:45:22]

On 2017/04/17 15:28:44, nikhil.sahni wrote:
> Hi Tyoshino,
> 
> I found a file beacon-basic-expected.txt, which tests the sendBeacon function
on
> bad URL's in beacon-basic.html
> 
> I think Changing these 2 lines from SyntaxError to TypeError will be fine I
> guess for LayoutTests. 
> 
> Plz let me know if this is fine ? then I'll push the changes.
> 
> PASS navigator.sendBeacon('http:') threw exception SyntaxError: Failed to
> execute 'sendBeacon' on 'Navigator': The URL argument is ill-formed or
> unsupported..
> PASS navigator.sendBeacon('javascript:alert(1);') threw exception SyntaxError:
> Failed to execute 'sendBeacon' on 'Navigator': Beacons are only supported over
> HTTP(S)..

Oh, OK. Then, you don't have to add a new test but just need to update those
expectations, right. Please upload a new patchset, yes, with the changes on the
test.

[Srirama, 2017-04-18 06:21:59]

The CQ bit was checked by srirama.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 06:22:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 07:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 07:54:35]

Dry run: This issue passed the CQ dry run.

[nikhil.sahni, 2017-04-18 09:04:49]

Hi Tyoshino

2 Layout tests were failing prior to the new changes.

After changing these 2 layout tests there is no layout test failure related to
sendBeacon and dry run looks good.

Thanks

[tyoshino (SeeGerritForStatus), 2017-04-18 09:06:21]

Thank you. Patch set 2 lgtm.

[nikhil.sahni, 2017-04-18 09:07:32]

The CQ bit was checked by nikhil.sahni@samsung.com

[commit-bot: I haz the power, 2017-04-18 09:07:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2017-04-18 09:08:20]

On 2017/04/18 09:06:21, tyoshino wrote:
> Thank you. Patch set 2 lgtm.

Checked AUTHORS and CLA: OK

[commit-bot: I haz the power, 2017-04-18 09:11:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492506452350170,
"parent_rev": "a377281d4100e91855312b96e98cea4c8fb34791", "commit_rev":
"0cfcab89310f8e7ad6db537c686200c0f545b613"}

[commit-bot: I haz the power, 2017-04-18 09:11:10]

Description was changed from

==========
sendBeacon should throw a TypeError on bad URLs.

sendBeacon should throw a TypeError on bad URLs
instead of syntax error.

Bug=660241
==========

to

==========
sendBeacon should throw a TypeError on bad URLs.

sendBeacon should throw a TypeError on bad URLs
instead of syntax error.

Bug=660241

Review-Url: https://codereview.chromium.org/2818563004
Cr-Commit-Position: refs/heads/master@{#465183}
Committed:
https://chromium.googlesource.com/chromium/src/+/0cfcab89310f8e7ad6db537c6862...
==========

[commit-bot: I haz the power, 2017-04-18 09:11:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0cfcab89310f8e7ad6db537c6862...