milo/appengine/swarming/buildinfo.go - Issue 2818563002: Milo: ACLs for internal swarm jobs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/swarming/buildinfo.go

Issue 2818563002: Milo: ACLs for internal swarm jobs (Closed)

Patch Set: Review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/appengine/swarming/buildinfo.go

diff --git a/milo/appengine/swarming/buildinfo.go b/milo/appengine/swarming/buildinfo.go

index b087f904893e5f17a332c75643a6dadbb7f67afd..0f7361de3a18bfe998d54bbd1ca2c77006ae16bd 100644

--- a/milo/appengine/swarming/buildinfo.go

+++ b/milo/appengine/swarming/buildinfo.go

@@ -65,7 +65,7 @@ func (p *BuildInfoProvider) GetBuildInfo(c context.Context, req *milo.BuildInfoR

fr, err := swarmingFetch(c, sf, req.Task, fetchParams)

if err != nil {

if err == errNotMiloJob {

- logging.Warningf(c, "User requested non-Milo task.")

+ logging.Warningf(c, "User requested nonexistent task or does not have permissions.")

return nil, grpcutil.NotFound

}