Milo: ACLs for internal swarm jobs

milo/appengine/swarming/buildinfo.go

 // Copyright 2017 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package swarming
 
 import (
         "strconv"
         "strings"
         "unicode/utf8"
@@ skipping 47 matching lines @@
         host := sf.getHost()
         logging.Infof(c, "Loading build info for Swarming host %s, task %s.", host, req.Task)
 
         fetchParams := swarmingFetchParams{
                 fetchReq: true,
                 fetchRes: true,
         }
         fr, err := swarmingFetch(c, sf, req.Task, fetchParams)
         if err != nil {
                 if err == errNotMiloJob {
-                        logging.Warningf(c, "User requested non-Milo task.")
+                        logging.Warningf(c, "User requested nonexistent task or does not have permissions.")
                         return nil, grpcutil.NotFound
                 }
 
                 logging.WithError(err).Errorf(c, "Failed to load Swarming task.")
                 return nil, grpcutil.Internal
         }
 
         // Determine the LogDog annotation stream path for this Swarming task.
         //
         // On failure, will return a gRPC error.
@@ skipping 188 matching lines @@
         lastChar, lastCharSize := utf8.DecodeLastRuneInString(taskID)
         v, err := strconv.ParseUint(string(lastChar), 16, 8)
         if err != nil {
                 return "", errors.Annotate(err).Reason("failed to parse hex from rune: %(rune)r").
                         D("rune", lastChar).
                         Err()
         }
 
         return taskID[:len(taskID)-lastCharSize] + strconv.FormatUint((v|uint64(tryNumber)), 16), nil
 }