Fix backface-visibility with will-change

Fix backface-visibility with will-change

In the case where there is a scrollbar with will-change property and its
backface-visibility is set to hidden, the scrollbar will show up when
it is back-flipped. The reason is that we are not setting the backface
visibility for the overflow_controls_host_layer_.

A layout test is added.

BUG=700013
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2818533004
Cr-Commit-Position: refs/heads/master@{#464782}
Committed: https://chromium.googlesource.com/chromium/src/+/ab9fb6945b8d58a04bf92eb4dd16f0cd585da359

[xidachen, 2017-04-13 15:01:28]

Description was changed from

==========
WIP: Fix backface-visibility with will-change

In the case where there is a scrollbar with will-change property and its
backface-visibility is set to hidden, the scrollbar will show up when
it is back-flipped. The reason is that we are not setting the backface
visibility for the overflow_controls_host_layer_.

BUG=700013
==========

to

==========
WIP: Fix backface-visibility with will-change

In the case where there is a scrollbar with will-change property and its
backface-visibility is set to hidden, the scrollbar will show up when
it is back-flipped. The reason is that we are not setting the backface
visibility for the overflow_controls_host_layer_.

BUG=700013
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[xidachen, 2017-04-13 19:42:06]

Description was changed from

==========
WIP: Fix backface-visibility with will-change

In the case where there is a scrollbar with will-change property and its
backface-visibility is set to hidden, the scrollbar will show up when
it is back-flipped. The reason is that we are not setting the backface
visibility for the overflow_controls_host_layer_.

BUG=700013
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
WIP: Fix backface-visibility with will-change

In the case where there is a scrollbar with will-change property and its
backface-visibility is set to hidden, the scrollbar will show up when
it is back-flipped. The reason is that we are not setting the backface
visibility for the overflow_controls_host_layer_.

A layout test is added.

BUG=700013
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[xidachen, 2017-04-13 19:42:06]

xidachen@chromium.org changed reviewers:
+ schenney@chromium.org

[xidachen, 2017-04-13 19:42:18]

Description was changed from

==========
WIP: Fix backface-visibility with will-change

In the case where there is a scrollbar with will-change property and its
backface-visibility is set to hidden, the scrollbar will show up when
it is back-flipped. The reason is that we are not setting the backface
visibility for the overflow_controls_host_layer_.

A layout test is added.

BUG=700013
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix backface-visibility with will-change

In the case where there is a scrollbar with will-change property and its
backface-visibility is set to hidden, the scrollbar will show up when
it is back-flipped. The reason is that we are not setting the backface
visibility for the overflow_controls_host_layer_.

A layout test is added.

BUG=700013
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[xidachen, 2017-04-13 19:43:29]

PTAL.

I looked at the failing layout tests on the slimming_paint_v2 trybot, and I
think the failure is due to flakyness.

[Stephen Chennney, 2017-04-13 19:48:33]

Can the test be reduced at all? There's a lot going on there.

For the SPv2 failure, please add a line to
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2

Otherwise the fix seem fine to me.

[xidachen, 2017-04-13 19:50:17]

On 2017/04/13 19:48:33, Stephen Chennney wrote:
> Can the test be reduced at all? There's a lot going on there.
> 
> For the SPv2 failure, please add a line to
> third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
> 
> Otherwise the fix seem fine to me.

Sure, I will try to reduce the test further.

[xidachen, 2017-04-13 21:31:25]

On 2017/04/13 19:48:33, Stephen Chennney wrote:
> Can the test be reduced at all? There's a lot going on there.
> 
> For the SPv2 failure, please add a line to
> third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
> 
> Otherwise the fix seem fine to me.

I have reduced the test and added an entry in the expectation file.

PTAL

[Stephen Chennney, 2017-04-14 15:28:41]

Thanks. lgtm.

[xidachen, 2017-04-14 18:39:03]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2017-04-14 18:39:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 20:00:31]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1492195143077150,
"parent_rev": "10df6d1026423b24dab397ff68a80e0ea97f6cfe", "commit_rev":
"ab9fb6945b8d58a04bf92eb4dd16f0cd585da359"}

[commit-bot: I haz the power, 2017-04-14 20:01:23]

Description was changed from

==========
Fix backface-visibility with will-change

In the case where there is a scrollbar with will-change property and its
backface-visibility is set to hidden, the scrollbar will show up when
it is back-flipped. The reason is that we are not setting the backface
visibility for the overflow_controls_host_layer_.

A layout test is added.

BUG=700013
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix backface-visibility with will-change

In the case where there is a scrollbar with will-change property and its
backface-visibility is set to hidden, the scrollbar will show up when
it is back-flipped. The reason is that we are not setting the backface
visibility for the overflow_controls_host_layer_.

A layout test is added.

BUG=700013
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2818533004
Cr-Commit-Position: refs/heads/master@{#464782}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab9fb6945b8d58a04bf92eb4dd16...
==========

[commit-bot: I haz the power, 2017-04-14 20:01:24]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/ab9fb6945b8d58a04bf92eb4dd16...