chrome/browser/metrics/chromeos_metrics_provider_unittest.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: still need to check MessageLoop::current() in Mojo's RunLoopNestingObserver::GetForThread() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

diff --git a/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc b/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

index 76f8ac0bb5832816a6f51762a63e2e0b7cc29f39..1e8357acfda65ae08549f94017bf1cfc8f53b1a9 100644

--- a/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

+++ b/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc

@@ -132,7 +132,7 @@ class TestChromeOSMetricsProvider : public ChromeOSMetricsProvider {

base::RunLoop().Run();

}

void GetBluetoothAdapterCallback() {

- ASSERT_TRUE(base::MessageLoop::current()->is_running());

+ ASSERT_TRUE(base::RunLoop::IsRunningOnCurrentThread());

base::MessageLoop::current()->QuitWhenIdle();

}

};