chrome/browser/ui/views/simple_message_box_views.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/simple_message_box_views.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: still need to check MessageLoop::current() in Mojo's RunLoopNestingObserver::GetForThread() Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/simple_message_box_views.cc

diff --git a/chrome/browser/ui/views/simple_message_box_views.cc b/chrome/browser/ui/views/simple_message_box_views.cc

index 91c219394eff2a5b098cd8d88d6deecae3c9b67b..972b848334d592c12ea43d0c939aae813a64ee0b 100644

--- a/chrome/browser/ui/views/simple_message_box_views.cc

+++ b/chrome/browser/ui/views/simple_message_box_views.cc

@@ -223,7 +223,7 @@ MessageBoxResult ShowMessageBoxImpl(gfx::NativeWindow parent,

// Fallback to logging with a default response or a Windows MessageBox.

#if defined(OS_WIN)

if (!base::MessageLoopForUI::IsCurrent() ||

- !base::MessageLoopForUI::current()->is_running() ||

+ !base::RunLoop::IsRunningOnCurrentThread() ||

!ResourceBundle::HasSharedInstance()) {

LOG_IF(ERROR, !checkbox_text.empty()) << "Dialog checkbox won't be shown";

int result = ui::MessageBox(views::HWNDForNativeWindow(parent), message,