Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)
Patch Set: need to RunUntilIdle for ConnectProfile with DoNothing callbacks -- how did this possibly not hang … Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
index 6215f4017c61d3ccf517ebf852bfbbe2a91ee3f5..243f0d9e1ad29f4ff596a8c3f91e7871feb157da 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
@@ -14,6 +14,7 @@
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/pending_task.h"
+#include "base/run_loop.h"
#include "base/synchronization/lock.h"
#include "base/threading/thread_checker.h"
#include "platform/scheduler/base/enqueue_order.h"
@@ -53,7 +54,7 @@ class TaskTimeObserver;
//
class BLINK_PLATFORM_EXPORT TaskQueueManager
: public internal::TaskQueueSelector::Observer,
- public base::MessageLoop::NestingObserver {
+ public base::RunLoop::NestingObserver {
public:
// Create a task queue manager where |delegate| identifies the thread
// on which where the tasks are eventually run. Category strings must have
@@ -236,8 +237,8 @@ class BLINK_PLATFORM_EXPORT TaskQueueManager
void OnTriedToSelectBlockedWorkQueue(
internal::WorkQueue* work_queue) override;
- // base::MessageLoop::NestingObserver implementation:
- void OnBeginNestedMessageLoop() override;
+ // base::RunLoop::NestingObserver implementation:
+ void OnBeginNestedRunLoop() override;
// Called by the task queue to register a new pending task.
void DidQueueTask(const internal::TaskQueueImpl::Task& pending_task);

Powered by Google App Engine
This is Rietveld 408576698