third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: need to RunUntilIdle for ConnectProfile with DoNothing callbacks -- how did this possibly not hang … Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluez/bluetooth_socket_bluez_unittest.cc ('K') | « third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h ('k') | third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

index 629495dda26b7dd1d964b4251b18c5db26a364e8..5d964e8414cbb68b69ea9a3d83cf5be411d58945 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

@@ -180,7 +180,7 @@ void TaskQueueManager::WakeUpReadyDelayedQueues(LazyNow* lazy_now) {

}

-void TaskQueueManager::OnBeginNestedMessageLoop() {

+void TaskQueueManager::OnBeginNestedRunLoop() {

// We just entered a nested message loop, make sure there's a DoWork posted or

// the system will grind to a halt.

{

@@ -192,7 +192,7 @@ void TaskQueueManager::OnBeginNestedMessageLoop() {

// When a nested message loop starts, task time observers may want to ignore

// the current task.

for (auto& observer : task_time_observers_)

- observer.OnBeginNestedMessageLoop();

+ observer.OnBeginNestedRunLoop();

delegate_->PostTask(FROM_HERE, immediate_do_work_closure_);

}