mash/quick_launch/quick_launch.cc - Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/quick_launch/quick_launch.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)

Patch Set: need to RunUntilIdle for ConnectProfile with DoNothing callbacks -- how did this possibly not hang … Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mash/quick_launch/quick_launch.cc

diff --git a/mash/quick_launch/quick_launch.cc b/mash/quick_launch/quick_launch.cc

index df88763a4c1b512a087311a94146a563e4665142..eaef8203ef16ac1425857ab0cf8f219aa628d4ed 100644

--- a/mash/quick_launch/quick_launch.cc

+++ b/mash/quick_launch/quick_launch.cc

@@ -7,6 +7,7 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/string16.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

@@ -166,7 +167,7 @@ void QuickLaunch::RemoveWindow(views::Widget* window) {

auto it = std::find(windows_.begin(), windows_.end(), window);

DCHECK(it != windows_.end());

windows_.erase(it);

- if (windows_.empty() && base::MessageLoop::current()->is_running())

+ if (windows_.empty() && base::RunLoop::IsRunningOnCurrentThread())

base::MessageLoop::current()->QuitWhenIdle();

}