Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: extensions/browser/api/alarms/alarms_api_unittest.cc

Issue 2818533003: Make nesting/running states a RunLoop rather than a MessageLoop concept. (Closed)
Patch Set: need to RunUntilIdle for ConnectProfile with DoNothing callbacks -- how did this possibly not hang … Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/alarms/alarms_api_unittest.cc
diff --git a/extensions/browser/api/alarms/alarms_api_unittest.cc b/extensions/browser/api/alarms/alarms_api_unittest.cc
index 20ef94d2b831b0cbb62dff28dd1bbc400c58e22e..dfaac4a4d423007f8821b8ec99d83f688709a00d 100644
--- a/extensions/browser/api/alarms/alarms_api_unittest.cc
+++ b/extensions/browser/api/alarms/alarms_api_unittest.cc
@@ -7,6 +7,7 @@
#include <stddef.h>
#include "base/json/json_reader.h"
+#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/test/simple_test_clock.h"
#include "base/values.h"
@@ -36,7 +37,7 @@ class AlarmDelegate : public AlarmManager::Delegate {
~AlarmDelegate() override {}
void OnAlarm(const std::string& extension_id, const Alarm& alarm) override {
alarms_seen.push_back(alarm.js_alarm->name);
- if (base::MessageLoop::current()->is_running())
+ if (base::RunLoop::IsRunningOnCurrentThread())
base::MessageLoop::current()->QuitWhenIdle();
}

Powered by Google App Engine
This is Rietveld 408576698