Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 2818513002: Fix -Wshorten-64-to-32 in test-assembler-arm64.cc (Closed)

Created:
3 years, 8 months ago by hans
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Fix -Wshorten-64-to-32 in test-assembler-arm64.cc The arm64 MacroAssembler expects buffer_size to be an unsigned, not a size_t. BUG=chromium:710913 Review-Url: https://codereview.chromium.org/2818513002 Cr-Commit-Position: refs/heads/master@{#44623} Committed: https://chromium.googlesource.com/v8/v8/+/b2dc9230c14f3b1dd6e5231457a8d157c39b8489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M test/cctest/test-assembler-arm64.cc View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hans
Please take a look.
3 years, 8 months ago (2017-04-12 17:27:53 UTC) #2
Michael Achenbach
lgtm, thanks
3 years, 8 months ago (2017-04-12 18:41:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818513002/1
3 years, 8 months ago (2017-04-12 18:42:54 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 18:44:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b2dc9230c14f3b1dd6e5231457a8d157c39...

Powered by Google App Engine
This is Rietveld 408576698