Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2818493002: Revert of Fix broken draw/upload paths from videos to 2D canvas and WebGL. (Closed)

Created:
3 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, Justin Novosad, Kai Ninomiya, piman+watch_chromium.org, posciak+watch_chromium.org, qiankun, Zhenyao Mo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix broken draw/upload paths from videos to 2D canvas and WebGL. (patchset #13 id:230001 of https://codereview.chromium.org/2791813003/ ) Reason for revert: Broke conformance/extensions/oes-texture-float-with-video.html on Android with NVIDIA GPUs: http://crbug.com/710874 . Original issue's description: > Fix broken draw/upload paths from videos to 2D canvas and WebGL. > > The fix for Issue 672895 made these video rendering and upload paths > fragile if the video's metadata caused the natural size to differ in > certain ways from the coded size. Make the code robust to this case by > reverting to CopyTextureCHROMIUM in most cases, and allocating the > texture to the correct sizes in others. > > Tested with new WebGL conformance test to be incorporated in a > forthcoming roll: https://github.com/KhronosGroup/WebGL/pull/2359 . > > BUG=701060 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2791813003 > Cr-Commit-Position: refs/heads/master@{#463925} > Committed: https://chromium.googlesource.com/chromium/src/+/0cc4c62a163318c06636916b7e2b2c6a56f16b74 TBR=dalecurtis@chromium.org,dglazkov@chromium.org,liberato@chromium.org,sandersd@chromium.org,tobiasjs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=701060 Review-Url: https://codereview.chromium.org/2818493002 Cr-Commit-Position: refs/heads/master@{#464052} Committed: https://chromium.googlesource.com/chromium/src/+/fe3f46f92f93b06b429c51439cbb846d42c0521f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -155 lines) Patch
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +1 line, -5 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 2 chunks +6 lines, -15 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 7 chunks +24 lines, -85 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 7 chunks +16 lines, -24 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Ken Russell (switch to Gerrit)
Created Revert of Fix broken draw/upload paths from videos to 2D canvas and WebGL.
3 years, 8 months ago (2017-04-12 16:22:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818493002/1
3 years, 8 months ago (2017-04-12 16:23:04 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 16:34:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe3f46f92f93b06b429c51439cbb...

Powered by Google App Engine
This is Rietveld 408576698