Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2818483002: [Reland] Add gesture support in views::ResizeArea (Closed)

Created:
3 years, 8 months ago by tdanderson
Modified:
3 years, 8 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Add gesture support in views::ResizeArea Reland of https://codereview.chromium.org/2796303006/. Original CL description: Add gesture (touch) support in views::ResizeArea, which is used for resizing the location bar. This area is located directly to the right of the location bar. BUG=320544 TEST=ResizeAreaTest.* Review-Url: https://codereview.chromium.org/2818483002 Cr-Commit-Position: refs/heads/master@{#464405} Committed: https://chromium.googlesource.com/chromium/src/+/56d2fdda34f895208a7cc0156c53161bb660320e

Patch Set 1 #

Patch Set 2 : unique_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -17 lines) Patch
M ui/views/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/resize_area.h View 3 chunks +9 lines, -6 lines 0 comments Download
M ui/views/controls/resize_area.cc View 3 chunks +21 lines, -10 lines 0 comments Download
M ui/views/controls/resize_area_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
A ui/views/controls/resize_area_unittest.cc View 1 1 chunk +200 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tdanderson
Sadrul, can you please take a look? PS1 is the original patch.
3 years, 8 months ago (2017-04-12 15:40:28 UTC) #4
sadrul
lgtm
3 years, 8 months ago (2017-04-13 13:39:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818483002/20001
3 years, 8 months ago (2017-04-13 14:43:14 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 15:13:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/56d2fdda34f895208a7cc0156c53...

Powered by Google App Engine
This is Rietveld 408576698