Wait for the battery level before starting encryption migration.

Wait for the battery level before starting encryption migration.

To avoid unexpected shutdowns during migration, we should ensure that the
battery level is enough before starting migration.

The expected behavior is as follows:
1) When "Upgrade" button is pressed and battery is enough,
start migration immediately.
2) When "Upgrade" button is pressed and battery is low,
ask the user to charge the device on the UI, disable the "Upgrade" button,
and start migration once the battery level gets enough.
3) When resuming previous migration and battery is enouch,
start migration immediately.
4) When resuming previous migration and battery is low,
ask the user to charge the device on the UI, hide all action buttons,
and start migration once the battery gets enough.

BUG=706017
TEST=manually tested the described expected behaviors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2818433002
Cr-Commit-Position: refs/heads/master@{#464251}
Committed: https://chromium.googlesource.com/chromium/src/+/98210114c0ce20499946176a3d9cdabbe6c2e701

[fukino, 2017-04-12 09:06:59]

Description was changed from

==========
Wait for the battery level before starting encryption migration.

BUG=
==========

to

==========
Wait for the battery level before starting encryption migration.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-04-12 09:15:43]

Description was changed from

==========
Wait for the battery level before starting encryption migration.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Wait for the battery level before starting encryption migration.

To avoid unexpected shutdowns during migration, we should ensure that the
battery level is enough before starting migration.

The expected behavior is as follows:
1) When "Upgrade" button is pressed and battery is enough,
start migration immediately.
2) When "Upgrade" button is pressed and battery is low,
ask the user to charge the device on the UI, disable the "Upgrade" button,
and start migration once the battery level gets enough.
3) When resuming previous migration and battery is enouch,
start migration immediately.
4) When resuming previous migration and battery is low,
ask the user to charge the device on the UI, hide all action buttons,
and start migration once the battery gets enough.

BUG=706017
TEST=manually tested the described expected behaviors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-04-12 09:16:47]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 09:17:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 10:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 10:11:29]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-04-12 11:29:00]

fukino@chromium.org changed reviewers:
+ xiyuan@chromium.org

[fukino, 2017-04-12 11:29:01]

Hi Xiyuan, could you take a look?

https://codereview.chromium.org/2818433002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/encryption_migration.html (right):

https://codereview.chromium.org/2818433002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/encryption_migration.html:28: <template
is="dom-if" if="[[!isEnoughBattery]]">
I'm going to update the design to match the latest spec and make strings
internationalized in the next CL.

[xiyuan, 2017-04-12 16:56:57]

lgtm

https://codereview.chromium.org/2818433002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/encryption_migration.html (right):

https://codereview.chromium.org/2818433002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/encryption_migration.html:28: <template
is="dom-if" if="[[!isEnoughBattery]]">
On 2017/04/12 11:29:01, fukino wrote:
> I'm going to update the design to match the latest spec and make strings
> internationalized in the next CL.

Acknowledged.

https://codereview.chromium.org/2818433002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_encryption_migration.js
(right):

https://codereview.chromium.org/2818433002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_encryption_migration.js:91:
isMigrationAccepted;
nit: I would do 

  $('encryption-migration-element').isMigrationAccepted = true;

in 'upgrade' event handler around line 25 to avoid a round trip to C++.

[fukino, 2017-04-12 22:59:02]

Thank you!

https://codereview.chromium.org/2818433002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_encryption_migration.js
(right):

https://codereview.chromium.org/2818433002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_encryption_migration.js:91:
isMigrationAccepted;
On 2017/04/12 16:56:56, xiyuan wrote:
> nit: I would do 
> 
>   $('encryption-migration-element').isMigrationAccepted = true;
> 
> in 'upgrade' event handler around line 25 to avoid a round trip to C++.

Done.
I toggled isMigrationAccepted property inside <encryption-migration> element on
'upgrade' event handler.

[fukino, 2017-04-12 22:59:11]

The CQ bit was checked by fukino@chromium.org

[fukino, 2017-04-12 22:59:11]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2818433002/#ps20001
(title: "Update |isMigrationAccepted| inside encryption-migration element.")

[commit-bot: I haz the power, 2017-04-12 22:59:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 23:50:55]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fukino, 2017-04-13 02:10:09]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2017-04-13 02:10:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:29:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492049409838480,
"parent_rev": "7973462ca0558fbb68fa455fe45fcd3c98fd277d", "commit_rev":
"98210114c0ce20499946176a3d9cdabbe6c2e701"}

[commit-bot: I haz the power, 2017-04-13 02:30:41]

Description was changed from

==========
Wait for the battery level before starting encryption migration.

To avoid unexpected shutdowns during migration, we should ensure that the
battery level is enough before starting migration.

The expected behavior is as follows:
1) When "Upgrade" button is pressed and battery is enough,
start migration immediately.
2) When "Upgrade" button is pressed and battery is low,
ask the user to charge the device on the UI, disable the "Upgrade" button,
and start migration once the battery level gets enough.
3) When resuming previous migration and battery is enouch,
start migration immediately.
4) When resuming previous migration and battery is low,
ask the user to charge the device on the UI, hide all action buttons,
and start migration once the battery gets enough.

BUG=706017
TEST=manually tested the described expected behaviors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Wait for the battery level before starting encryption migration.

To avoid unexpected shutdowns during migration, we should ensure that the
battery level is enough before starting migration.

The expected behavior is as follows:
1) When "Upgrade" button is pressed and battery is enough,
start migration immediately.
2) When "Upgrade" button is pressed and battery is low,
ask the user to charge the device on the UI, disable the "Upgrade" button,
and start migration once the battery level gets enough.
3) When resuming previous migration and battery is enouch,
start migration immediately.
4) When resuming previous migration and battery is low,
ask the user to charge the device on the UI, hide all action buttons,
and start migration once the battery gets enough.

BUG=706017
TEST=manually tested the described expected behaviors.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2818433002
Cr-Commit-Position: refs/heads/master@{#464251}
Committed:
https://chromium.googlesource.com/chromium/src/+/98210114c0ce20499946176a3d9c...
==========

[commit-bot: I haz the power, 2017-04-13 02:30:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/98210114c0ce20499946176a3d9c...