Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 2818413002: Revert change to HeapAllocator::IsAllocationAllowed by r464359 (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert change to HeapAllocator::IsAllocationAllowed by r464359 BUG=709201 Review-Url: https://codereview.chromium.org/2818413002 Cr-Commit-Position: refs/heads/master@{#464905} Committed: https://chromium.googlesource.com/chromium/src/+/c5614bacedb1f26619aac05832a21c51143ba2d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
keishi
Reverting change to HeapAllocator::IsAllocationAllowed I made in https://codereview.chromium.org/2815663002/ . After haraken's comment#14 I meant to ...
3 years, 8 months ago (2017-04-17 06:36:20 UTC) #1
keishi
Reverting change to HeapAllocator::IsAllocationAllowed I made in https://codereview.chromium.org/2815663002/ . After haraken's comment#14 I meant to ...
3 years, 8 months ago (2017-04-17 06:36:39 UTC) #3
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-17 06:37:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818413002/1
3 years, 8 months ago (2017-04-17 06:38:48 UTC) #7
haraken
LGTM
3 years, 8 months ago (2017-04-17 06:39:25 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 08:27:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c5614bacedb1f26619aac05832a2...

Powered by Google App Engine
This is Rietveld 408576698