Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 2818273002: Remove parent_level field of function type parameters. (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index 2995bfab503dbe3d8b81dc6d9d6213188425e285..a0cc04a252f04cbb635304f0a222047ac6196c13 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -1722,7 +1722,11 @@ static void GenerateSubtypeNTestCacheStub(Assembler* assembler, int n) {
__ SmiTag(ECX);
__ cmpl(ECX, Immediate(Smi::RawValue(kClosureCid)));
__ j(NOT_EQUAL, &loop, Assembler::kNearJump);
- __ movl(EBX, FieldAddress(EAX, Closure::instantiator_offset()));
+ __ movl(EBX, FieldAddress(EAX, Closure::function_type_arguments_offset()));
+ __ cmpl(EBX, raw_null); // Cache cannot be used for generic closures.
+ __ j(NOT_EQUAL, &not_found, Assembler::kNearJump);
+ __ movl(EBX,
+ FieldAddress(EAX, Closure::instantiator_type_arguments_offset()));
__ movl(ECX, FieldAddress(EAX, Closure::function_offset()));
// ECX: instance class id as Smi or function.
__ Bind(&loop);
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698