Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: runtime/lib/function.dart

Issue 2818273002: Remove parent_level field of function type parameters. (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/function.cc ('k') | runtime/lib/mirrors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/function.dart
diff --git a/runtime/lib/function.dart b/runtime/lib/function.dart
index f8187e9ce5fd0ceb2f2f207f9716c3b8b7c3fba2..7f0556de37369ccc5dda11d71eea2b0e25f49832 100644
--- a/runtime/lib/function.dart
+++ b/runtime/lib/function.dart
@@ -11,19 +11,16 @@ class _Closure implements Function {
_Closure _clone() native "Closure_clone";
- // No instance fields should be declared before the following 3 fields whose
+ // No instance fields should be declared before the following 4 fields whose
// offsets must be identical in Dart and C++.
- // The following 3 fields are declared both in raw_object.h (for direct access
+ // The following 4 fields are declared both in raw_object.h (for direct access
// from C++ code) and also here so that the offset-to-field map used by
// deferred objects is properly initialized.
- // Caution: These fields are not Dart instances, but VM objects.
- // The fields had to be renamed here so that they would be private fields
- // in dart
- // instantiator_ ===> _instantiator
- // function_ ===> _function
- // context_ ===> _context
- var _instantiator;
+ // Caution: These fields are not Dart instances, but VM objects. Their Dart
+ // names do not need to match the C++ names, but they must be private.
+ var _instantiator_type_arguments;
+ var _function_type_arguments;
var _function;
var _context;
}
« no previous file with comments | « runtime/lib/function.cc ('k') | runtime/lib/mirrors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698