Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 2818193002: Log JumpListUpdater functions' execution time to UMA (Closed)

Created:
3 years, 8 months ago by chengx
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Log JumpListUpdater functions' execution time to UMA Recent UMA data shows that the UpdateJumpList method alone in jumplist.cc takes 1+ second for more than 1% Canary users. Therefore, it's worthwhile to investigate all the pieces of this method, which is JumpListUpdater class related. BUG=40407, 179576 Review-Url: https://codereview.chromium.org/2818193002 Cr-Commit-Position: refs/heads/master@{#464997} Committed: https://chromium.googlesource.com/chromium/src/+/ce5d2adea8adbc9e950371ef08513de8e83d790d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M chrome/browser/win/jumplist_updater.cc View 5 chunks +14 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
chengx
PTAL, thanks! gab@ for jumplist_updater.cc isherman@ for histograms.xml
3 years, 8 months ago (2017-04-14 20:18:03 UTC) #3
Ilya Sherman
lgtm
3 years, 8 months ago (2017-04-14 20:22:10 UTC) #5
chengx
Gentle ping~ Adding another file owner pmonette@ in case gab@ is busy.
3 years, 8 months ago (2017-04-17 18:33:29 UTC) #7
Patrick Monette
lgtm
3 years, 8 months ago (2017-04-17 19:09:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818193002/1
3 years, 8 months ago (2017-04-17 19:11:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ce5d2adea8adbc9e950371ef08513de8e83d790d
3 years, 8 months ago (2017-04-17 20:20:37 UTC) #13
gab
3 years, 8 months ago (2017-04-18 19:14:43 UTC) #14
Message was sent while issue was closed.
lgtm, sorry for delay

Powered by Google App Engine
This is Rietveld 408576698