Open system menu when click the status tray with volume popup opend

ash/system/tray/system_tray.cc

Index: ash/system/tray/system_tray.cc
diff --git a/ash/system/tray/system_tray.cc b/ash/system/tray/system_tray.cc
index 6f6892a3a9c5708e4e8bd6d62f1f229f81e02d01..aa9708e48cd2f4bbfb6d5c28d8a6efa3c8bb421b 100644
--- a/ash/system/tray/system_tray.cc
+++ b/ash/system/tray/system_tray.cc
@@ -209,21 +209,7 @@ class SystemTray::ActivationObserver
 
 // SystemTray
 
-SystemTray::SystemTray(WmShelf* wm_shelf)
-    : TrayBackgroundView(wm_shelf, true),
-      web_notification_tray_(nullptr),
-      detailed_item_(nullptr),
-      default_bubble_height_(0),
-      full_system_tray_menu_(false),
-      tray_accessibility_(nullptr),
-      tray_audio_(nullptr),
-      tray_cast_(nullptr),
-      tray_network_(nullptr),
-      tray_tiles_(nullptr),
-      tray_system_info_(nullptr),
-      tray_update_(nullptr),
-      screen_capture_tray_item_(nullptr),
-      screen_share_tray_item_(nullptr) {
+SystemTray::SystemTray(WmShelf* wm_shelf) : TrayBackgroundView(wm_shelf, true) {
   SetInkDropMode(InkDropMode::ON);
 
   // Since user avatar is on the right hand side of System tray of a
@@ -344,6 +330,7 @@ void SystemTray::ShowDetailedView(SystemTrayItem* item,
                                   int close_delay,
                                   bool activate,
                                   BubbleCreationType creation_type) {
+  detailed_view_with_close_delay_ = close_delay > 0 ? true : false;

[tdanderson, 2017/04/18 17:59:14]

I think you can just say = close_delay > 0 here instead of using a ternary.

Also, I am concerned about this member staying up-to-date. Would you also want
to modify this member in cases such as:

* If SystemTray::SetDetailedViewCloseDelay() is called
* (maybe) when the detailed view closes?

And/or you should also update the member documentation to clarify that this
member only has meaning IF a detailed view is currently open.

[minch1, 2017/04/18 18:29:34]

I think the ternary here is necessary. Since every time 'ShowDetailedView' is
called, the variable detailed_view_with_close_delay will be updated according to
the type of the detailed view (popup with close_delay or detailed view in system
menu without close_delay)

[tdanderson, 2017/04/19 16:10:40]

I agree that you should be updating |detailed_view_with_close_delay_| here, but
my comment is that I think you can just write this:

detailed_view_with_close_delay_ = close_delay > 0;

instead of this:

detailed_view_with_close_delay_ = close_delay > 0 ? true : false;

   std::vector<SystemTrayItem*> items;
   // The detailed view with timeout means a UI to show the current system state,
   // like the audio level or brightness. Such UI should behave as persistent and
@@ -698,9 +685,11 @@ void SystemTray::ActivateBubble() {
 }
 
 bool SystemTray::PerformAction(const ui::Event& event) {
-  // If we're already showing the menu, hide it; otherwise, show it (and hide
-  // any popup that's currently shown).
-  if (HasSystemBubble()) {
+  // If we're already showing the default view or detailed view in system menu,
+  // hide it; otherwise, show it (and hide any popup that's currently shown).
+  if (HasSystemBubbleType(SystemTrayBubble::BUBBLE_TYPE_DEFAULT) ||
+      (HasSystemBubbleType(SystemTrayBubble::BUBBLE_TYPE_DETAILED) &&
+       !detailed_view_with_close_delay_)) {

[tdanderson, 2017/04/18 17:59:14]

With this change, if you:

* Open the system menu
* Open one of the detailed views (a11y for instance)
* Click the tray button

What happens? From reading this it seems like the menu won't close, and this
would be regressing the change you made in
https://codereview.chromium.org/2784163003

[minch1, 2017/04/18 18:29:34]

I tried this in my device. The system menu will be closed correctly in this
scenario. Since detailed_view_with_close_delay_ is updated in ShowDetailedView. 

[tdanderson, 2017/04/19 16:10:40]

You're right, I was reading this incorrectly. What you have here will work.

     system_bubble_->bubble()->Close();
   } else {
     ShowDefaultView(BUBBLE_CREATE_NEW);