Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2784163003:
Dismiss the system menu if the status area is clicked while the menu is open. (Closed)
|
Created:
3 years, 8 months ago by minch1 Modified:
3 years, 8 months ago Reviewers:
tdanderson CC:
chromium-reviews, kalyank, sadrul Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDismiss the system menu if the status area is clicked while the menu is open.
BUG=690112
Review-Url: https://codereview.chromium.org/2784163003
Cr-Commit-Position: refs/heads/master@{#461243}
Committed: https://chromium.googlesource.com/chromium/src/+/70395486c5552329b3cd1e9658d017128840431e
Patch Set 1 #
Total comments: 2
Patch Set 2 : Adress the coments on PS#1 #Patch Set 3 : Adress the coments on PS#1 #Messages
Total messages: 31 (25 generated)
Description was changed from ========== Dismiss the system menu if the status area is clicked while the menu is open. BUG=690112 ========== to ========== Dismiss the system menu if the status area is clicked while the menu is open. BUG=690112 ==========
minch@chromium.org changed reviewers: + tdanderson@chromium.org
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by minch@chromium.org
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi, tdanderson@, can you help take a look? Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Looks good, just a couple of comments below. https://codereview.chromium.org/2784163003/diff/1/ash/common/system/tray/syst... File ash/common/system/tray/system_tray.cc (right): https://codereview.chromium.org/2784163003/diff/1/ash/common/system/tray/syst... ash/common/system/tray/system_tray.cc:710: // If we're already showing the menu (whatever default view or detailed view, nit: no need to mention the bug number in the comments. You can just reword this comment as: "If we're already showing the menu, hide it. Otherwise, show it and hide any popup that's currently shown." https://codereview.chromium.org/2784163003/diff/1/ash/common/system/tray/syst... ash/common/system/tray/system_tray.cc:713: if (system_bubble_.get()) { nit: call HasSystemBubble() here instead
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tdanderson@, can you help take a look again? Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patch set 2 LGTM
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by minch@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tdanderson@chromium.org Link to the patchset: https://codereview.chromium.org/2784163003/#ps40001 (title: "Adress the coments on PS#1")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490997342500320,
"parent_rev": "19654a032a321c75d46e36b63d428d206a678ccf", "commit_rev":
"70395486c5552329b3cd1e9658d017128840431e"}
Message was sent while issue was closed.
Description was changed from ========== Dismiss the system menu if the status area is clicked while the menu is open. BUG=690112 ========== to ========== Dismiss the system menu if the status area is clicked while the menu is open. BUG=690112 Review-Url: https://codereview.chromium.org/2784163003 Cr-Commit-Position: refs/heads/master@{#461243} Committed: https://chromium.googlesource.com/chromium/src/+/70395486c5552329b3cd1e9658d0... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/70395486c5552329b3cd1e9658d0... |
