Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 2818173003: Indexed DB: Remove nonstandard IDBFactory.webkitGetDatabaseNames() (Closed)

Created:
8 months, 1 week ago by jsbell
Modified:
7 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, cmumford, falken+watch_chromium.org, haraken, horo+watch_chromium.org, jsbell+idb_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, mac-reviews_chromium.org, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Indexed DB: Remove nonstandard IDBFactory.webkitGetDatabaseNames() Deprecated in M58, now removing in M60 per the plan. Intent to Deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/2fUr-3wFPKI/discussion Intent to Remove: https://groups.google.com/a/chromium.org/d/topic/blink-dev/A6m1Pt9-BAo/discussion Chrome Status Entry: https://www.chromestatus.com/features/5725741740195840 BUG=696010 Review-Url: https://codereview.chromium.org/2818173003 Cr-Commit-Position: refs/heads/master@{#473255} Committed: https://chromium.googlesource.com/chromium/src/+/7a400ee2cb54a4be1a7b4dc6a3d407693d3699a4

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Remove content_browsertest for wGDN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -378 lines) Patch
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/indexeddb/corrupted_open_db_detection.html View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/resources/sandboxed-iframe-storage-disallowed.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-storage-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-origin-indexeddb-allowed-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-origin-worker-indexeddb-allowed-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-indexeddb.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/resources/worker-for-indexeddb.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/factory-basics.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/factory-basics-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/factory-basics-workers.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/factory-basics-workers-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/getdatabasenames-failed-open.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/getdatabasenames-failed-open-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/storage/indexeddb/resources/factory-basics.js View 1 chunk +0 lines, -88 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.h View 1 2 3 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp View 1 2 3 chunks +13 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.idl View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 2 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 23 (19 generated)
jsbell
chrishtr@ - can you review?
7 months ago (2017-05-18 20:30:57 UTC) #10
chrishtr
lgtm
7 months ago (2017-05-18 20:45:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818173003/60001
7 months ago (2017-05-19 16:15:08 UTC) #20
commit-bot: I haz the power
7 months ago (2017-05-19 18:42:58 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7a400ee2cb54a4be1a7b4dc6a3d4...

Powered by Google App Engine
This is Rietveld 0eb02b776