Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2818153002: Fix release builds for iOS. Add stub chromium impl for preferences. (Closed)

Created:
3 years, 8 months ago by nicholss
Modified:
3 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix release builds for iOS. Add stub chromium impl for preferences. BUG=711612 Review-Url: https://codereview.chromium.org/2818153002 Cr-Commit-Position: refs/heads/master@{#464763} Committed: https://chromium.googlesource.com/chromium/src/+/3b1c2e7db1894fcb07f104d17343fa6912be2188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M remoting/client/ios/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nicholss
PTAL, band-aid to fix the release.
3 years, 8 months ago (2017-04-14 17:33:02 UTC) #2
Jamie
lgtm
3 years, 8 months ago (2017-04-14 17:41:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818153002/1
3 years, 8 months ago (2017-04-14 17:42:23 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 18:53:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b1c2e7db1894fcb07f104d17343...

Powered by Google App Engine
This is Rietveld 408576698