Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2818113002:
Enable telemetry_unittests on chromium.android:Marshmallow 64-bit Tester (Closed)
DescriptionEnable telemetry_unittests on chromium.android:Marshmallow 64-bit Tester
BUG=710037
Review-Url: https://codereview.chromium.org/2818113002
Cr-Commit-Position: refs/heads/master@{#464739}
Committed: https://chromium.googlesource.com/chromium/src/+/5f3a801f041786870d779585c2267e41a027cd25
Patch Set 1 #
Total comments: 3
Messages
Total messages: 17 (7 generated)
nednguyen@google.com changed reviewers: + jbudorick@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2818113002/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2818113002/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.json:3831: "hard_timeout": 960, this is 16 minutes, whereas the usual runtime of this on catapult CQ is 8 minutes 30s
lgtm w/ optional nit https://codereview.chromium.org/2818113002/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2818113002/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.json:3819: "override_compile_targets": [ optional nit: I don't think this is necessary any more, and I'm working on pulling these out of our configurations. If you'd like to keep it in for now for consistency, though, I'm ok with it.
https://codereview.chromium.org/2818113002/diff/1/testing/buildbot/chromium.a... File testing/buildbot/chromium.android.json (right): https://codereview.chromium.org/2818113002/diff/1/testing/buildbot/chromium.a... testing/buildbot/chromium.android.json:3819: "override_compile_targets": [ On 2017/04/14 16:12:55, jbudorick wrote: > optional nit: I don't think this is necessary any more, and I'm working on > pulling these out of our configurations. If you'd like to keep it in for now for > consistency, though, I'm ok with it. Yeah, if we remove these, I prefer doing that in a mass refactoring CL to keep the configs consistent.
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492187150250960, "parent_rev":
"4f57bb92e57ec92f0d7d1db53920f56725b6a74e", "commit_rev":
"5f3a801f041786870d779585c2267e41a027cd25"}
Message was sent while issue was closed.
Description was changed from ========== Enable telemetry_unittests on chromium.android:Marshmallow 64-bit Tester BUG=710037 ========== to ========== Enable telemetry_unittests on chromium.android:Marshmallow 64-bit Tester BUG=710037 Review-Url: https://codereview.chromium.org/2818113002 Cr-Commit-Position: refs/heads/master@{#464739} Committed: https://chromium.googlesource.com/chromium/src/+/5f3a801f041786870d779585c226... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5f3a801f041786870d779585c226...
Message was sent while issue was closed.
On 2017/04/14 17:09:15, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/5f3a801f041786870d779585c226... This breaks arm64 builder (dbg): https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20ar...
Message was sent while issue was closed.
On 2017/04/14 17:46:50, Ted C wrote: > On 2017/04/14 17:09:15, commit-bot: I haz the power wrote: > > Committed patchset #1 (id:1) as > > > https://chromium.googlesource.com/chromium/src/+/5f3a801f041786870d779585c226... > > This breaks arm64 builder (dbg): > https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20ar... telemetry_unittests is in a !is_android block? https://codesearch.chromium.org/chromium/src/chrome/test/BUILD.gn?rcl=2c8b831... hrm. How are we running this on the catapult CQ?
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2818973002/ by jbudorick@chromium.org. The reason for reverting is: telemetry_unittests isn't a target on Android at the moment..
Message was sent while issue was closed.
On 2017/04/14 17:51:00, jbudorick wrote: > On 2017/04/14 17:46:50, Ted C wrote: > > On 2017/04/14 17:09:15, commit-bot: I haz the power wrote: > > > Committed patchset #1 (id:1) as > > > > > > https://chromium.googlesource.com/chromium/src/+/5f3a801f041786870d779585c226... > > > > This breaks arm64 builder (dbg): > > > https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20ar... > > telemetry_unittests is in a !is_android block? > https://codesearch.chromium.org/chromium/src/chrome/test/BUILD.gn?rcl=2c8b831... > > hrm. How are we running this on the catapult CQ? We are running this on catapult CQ without building CHrome (using the android ref build) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
