fix url comment on HTMLDialogElement.cpp

fix url comment on HTMLDialogElement.cpp

Review-Url: https://codereview.chromium.org/2818103002
Cr-Commit-Position: refs/heads/master@{#467575}
Committed: https://chromium.googlesource.com/chromium/src/+/bb4bab6e5cfcaf5b8b8511fa6986d571f23cc034

[tgfjt, 2017-04-14 12:41:00]

The CQ bit was checked by tgfjt.mail@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 12:41:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 12:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 12:41:11]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[tgfjt, 2017-04-14 12:45:31]

Description was changed from

==========
fix url comment on HTMLDialogElement.cpp

BUG=
==========

to

==========
fix url comment on HTMLDialogElement.cpp

BUG=
==========

[tgfjt, 2017-04-14 12:45:32]

tgfjt.mail@gmail.com changed reviewers:
+ kochi@chromium.org

[kochi, 2017-04-26 10:19:09]

Oops sorry not noticing this for long time.
This change obviously l-g-t-m, but I'm wondering if this
needs you to sign legal agreement.
https://www.chromium.org/developers/contributing-code

If you already done signing the contributor's agreement,
it's fine, but let me check this case internally and get
you back.

[kochi, 2017-04-26 10:24:55]

Our internal record showed you already signed the
agreement in Jul. 2015.

Thanks for the contribution!

LGTM

[kochi, 2017-04-26 10:25:19]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2017-04-26 10:25:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 10:33:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 10:33:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kochi, 2017-04-26 10:50:23]

On 2017/04/26 10:33:45, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Hmm, you have signed the CLA, but not for Chromium project?
Let me check again and get back to you.

[kochi, 2017-04-26 10:59:44]

Okay, as far as I understand, could you do the following?

1. Include a change in AUTHORS file in Chromium's root
   directory.
   Add your "Name <email address>" in
   https://cs.chromium.org/chromium/src/AUTHORS
   (see also 
   http://www.chromium.org/developers/contributing-code )
2. You don't need BUG= line in the description
3. You need another OWNERS review for the directory
   (asking tkent@ on behalf of you)

[kochi, 2017-04-26 11:00:40]

kochi@chromium.org changed reviewers:
+ tkent@chromium.org

[kochi, 2017-04-26 11:00:40]

Okay, as far as I understand, could you do the following?

1. Include a change in AUTHORS file in Chromium's root
   directory.
   Add your "Name <email address>" in
   https://cs.chromium.org/chromium/src/AUTHORS
   (see also 
   http://www.chromium.org/developers/contributing-code )
2. You don't need BUG= line in the description
3. You need another OWNERS review for the directory
   (asking tkent@ on behalf of you)

[tgfjt, 2017-04-27 01:19:45]

Description was changed from

==========
fix url comment on HTMLDialogElement.cpp

BUG=
==========

to

==========
fix url comment on HTMLDialogElement.cpp
==========

[tgfjt, 2017-04-27 01:24:08]

On 2017/04/26 11:00:40, kochi wrote:
> Okay, as far as I understand, could you do the following?
> 
> 1. Include a change in AUTHORS file in Chromium's root
>    directory.
>    Add your "Name <email address>" in
>    https://cs.chromium.org/chromium/src/AUTHORS
>    (see also 
>    http://www.chromium.org/developers/contributing-code )
> 2. You don't need BUG= line in the description
> 3. You need another OWNERS review for the directory
>    (asking tkent@ on behalf of you)

Hi!

1. added my name<email> on AUTHORS.
2. remove `BUG=` from the description.
3. Do I just wait for reviewing?

Thanks.

[tkent, 2017-04-27 01:34:24]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-04-27 01:34:24]

lgtm

[tkent, 2017-04-27 01:34:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2818103002/#ps20001
(title: "fix url comment on HTMLDialogElement.cpp")

[commit-bot: I haz the power, 2017-04-27 01:35:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 04:00:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493256864305580,
"parent_rev": "050dbe550d14e99ad4e83093d4f4e79642b9edc3", "commit_rev":
"bb4bab6e5cfcaf5b8b8511fa6986d571f23cc034"}

[commit-bot: I haz the power, 2017-04-27 04:01:12]

Description was changed from

==========
fix url comment on HTMLDialogElement.cpp
==========

to

==========
fix url comment on HTMLDialogElement.cpp

Review-Url: https://codereview.chromium.org/2818103002
Cr-Commit-Position: refs/heads/master@{#467575}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb4bab6e5cfcaf5b8b8511fa6986...
==========

[commit-bot: I haz the power, 2017-04-27 04:01:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bb4bab6e5cfcaf5b8b8511fa6986...

[kochi, 2017-04-28 02:25:06]

@tgfjt Thanks for your contribution!