Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2818033003:
[Contextual Search] Disable narrow panel when Chrome Home is enabled (Closed)
Description[Contextual Search] Disable narrow panel when Chrome Home is enabled
BUG=706256
Review-Url: https://codereview.chromium.org/2818033003
Cr-Commit-Position: refs/heads/master@{#464926}
Committed: https://chromium.googlesource.com/chromium/src/+/66ab38ef527bbc588352b6fe547dab8b28a61c6a
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add null check for tests #
Messages
Total messages: 25 (16 generated)
The CQ bit was checked by twellington@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
twellington@chromium.org changed reviewers: + mdjones@chromium.org
mdjones@ - ptal donnd@ - fyi
lgtm
The CQ bit was unchecked by twellington@chromium.org
The CQ bit was checked by twellington@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by twellington@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
https://codereview.chromium.org/2818033003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java (right): https://codereview.chromium.org/2818033003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java:420: if (!mOverrideIsFullWidthSizePanelForTesting && mActivity.getBottomSheet() != null) { I need to add an mActivity != null check for the tests.
The CQ bit was checked by twellington@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by twellington@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org Link to the patchset: https://codereview.chromium.org/2818033003/#ps20001 (title: "Add null check for tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492445002183630,
"parent_rev": "fe1c747c077c99272ebbc2eafe7983b9b9e2d927", "commit_rev":
"66ab38ef527bbc588352b6fe547dab8b28a61c6a"}
Message was sent while issue was closed.
Description was changed from ========== [Contextual Search] Disable narrow panel when Chrome Home is enabled BUG=706256 ========== to ========== [Contextual Search] Disable narrow panel when Chrome Home is enabled BUG=706256 Review-Url: https://codereview.chromium.org/2818033003 Cr-Commit-Position: refs/heads/master@{#464926} Committed: https://chromium.googlesource.com/chromium/src/+/66ab38ef527bbc588352b6fe547d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/66ab38ef527bbc588352b6fe547d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
