Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 281803002: Revert of Don't use webmediaplayer to inform webview about fullscreen change (Closed)

Created:
6 years, 7 months ago by qinmin
Modified:
6 years, 7 months ago
Reviewers:
trchen
CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Revert of Don't use webmediaplayer to inform webview about fullscreen change (https://codereview.chromium.org/275163002/) Reason for revert: this will break webview due to poor support of fullscreen api Original issue's description: > Don't use webmediaplayer to inform webview about fullscreen change > > Currently we rely on webmediaplayer to inform webview about fullscreen change. > With https://codereview.chromium.org/277823002/, we no longer need to do so. > When entering fullscreen, the page will be resized to fullscreen, and that will call Will/DidEnterFullscreen for us. > When leaving the fullscreen, ToggleFullscreenForTab() will request the tab to exit fullscreen. That should trigger the Resize() call and send Will/DidExitFullscreen for us. > > BUG=367346 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270005 TBR=trchen@chromium.org NOTREECHECKS=true NOTRY=true BUG=367346 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M content/browser/media/android/browser_media_player_manager.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
qinmin
Created Revert of Don't use webmediaplayer to inform webview about fullscreen change
6 years, 7 months ago (2014-05-13 17:43:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/281803002/1
6 years, 7 months ago (2014-05-13 17:44:17 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 17:48:31 UTC) #3
Message was sent while issue was closed.
Change committed as 270141

Powered by Google App Engine
This is Rietveld 408576698