MD-Settings: A11y - Label power source and stylus drop downs.

MD-Settings: A11y - Label power source and stylus drop downs.

R=derat@chromium.org
BUG=710691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817973002
Cr-Commit-Position: refs/heads/master@{#464552}
Committed: https://chromium.googlesource.com/chromium/src/+/4f4530109b8b68643c6a3afbb239e21580d46a8a

[hcarmona, 2017-04-13 19:32:30]

Description was changed from

==========
MD-Settings: A11y - Label power source and stylus drop downs.

R=derat@chromium.org
BUG=710691
==========

to

==========
MD-Settings: A11y - Label power source and stylus drop downs.

R=derat@chromium.org
BUG=710691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2017-04-13 19:32:33]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[hcarmona, 2017-04-13 19:33:11]

PTAL

[commit-bot: I haz the power, 2017-04-13 19:33:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2017-04-13 19:40:17]

thanks!

https://codereview.chromium.org/2817973002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/stylus.html (right):

https://codereview.chromium.org/2817973002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/stylus.html:43: <div
id="stylusNoteTakingApp" class="start">
mind making this instead be something like stylusNoteTakingAppLabel so its role
is a bit clearer?

[hcarmona, 2017-04-13 20:27:22]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:27:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2017-04-13 20:27:48]

https://codereview.chromium.org/2817973002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/device_page/stylus.html (right):

https://codereview.chromium.org/2817973002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/device_page/stylus.html:43: <div
id="stylusNoteTakingApp" class="start">
On 2017/04/13 19:40:16, Daniel Erat wrote:
> mind making this instead be something like stylusNoteTakingAppLabel so its
role
> is a bit clearer?

Done.

[Daniel Erat, 2017-04-13 20:32:06]

lgtm

[hcarmona, 2017-04-13 20:37:08]

The CQ bit was unchecked by hcarmona@chromium.org

[hcarmona, 2017-04-13 20:37:08]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:37:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 21:34:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492115828639040,
"parent_rev": "9fcfc8861ae30d5f1f5acf2d4cc0237f7f4e4f59", "commit_rev":
"4f4530109b8b68643c6a3afbb239e21580d46a8a"}

[commit-bot: I haz the power, 2017-04-13 21:35:28]

Description was changed from

==========
MD-Settings: A11y - Label power source and stylus drop downs.

R=derat@chromium.org
BUG=710691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD-Settings: A11y - Label power source and stylus drop downs.

R=derat@chromium.org
BUG=710691
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817973002
Cr-Commit-Position: refs/heads/master@{#464552}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f4530109b8b68643c6a3afbb239...
==========

[commit-bot: I haz the power, 2017-04-13 21:35:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4f4530109b8b68643c6a3afbb239...