Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2817923003: aw: Add allow wait for form database (Closed)

Created:
3 years, 8 months ago by boliu
Modified:
3 years, 8 months ago
Reviewers:
sgurun-gerrit only, jam
CC:
chromium-reviews, danakj+watch_chromium.org, android-webview-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Add allow wait for form database Follow up fix to refs/heads/master@{#463849}. FormDatabase is similar to CookieManager. It's thread-safe singleton class that needs answers synchronously from the database thread in the public webview API. Missed this in the first round because there are no instrumentation tests covering this, so add a smoke test. BUG=711338 Review-Url: https://codereview.chromium.org/2817923003 Cr-Commit-Position: refs/heads/master@{#464637} Committed: https://chromium.googlesource.com/chromium/src/+/40b2b2d5c7a313d91e72096c3f07762801fd616c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M android_webview/browser/aw_form_database_service.cc View 2 chunks +5 lines, -1 line 0 comments Download
A android_webview/javatests/src/org/chromium/android_webview/test/AwFormDatabaseTest.java View 1 chunk +23 lines, -0 lines 0 comments Download
M android_webview/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/thread_restrictions.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
boliu
ptal jam for thread_restrictions sgurun for android_webview
3 years, 8 months ago (2017-04-13 17:52:07 UTC) #2
sgurun-gerrit only
On 2017/04/13 17:52:07, boliu wrote: > ptal > > jam for thread_restrictions > sgurun for ...
3 years, 8 months ago (2017-04-13 18:24:05 UTC) #3
jam
lgtm
3 years, 8 months ago (2017-04-13 23:10:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817923003/1
3 years, 8 months ago (2017-04-13 23:14:06 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 01:00:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40b2b2d5c7a313d91e72096c3f07...

Powered by Google App Engine
This is Rietveld 408576698