[Remote scheduler] Make sure we fetch after EULA accepted

[Remote scheduler] Make sure we fetch after EULA accepted

Previously, accepting EULA issued a browser-foregrounded trigger. This
trigger is now ignored on default in release channels.

This CL changes it to persistent fetch trigger so that we are sure the
initial fetch is performed, no matter how we change the params in the
future.

BUG=676662
Review-Url: https://codereview.chromium.org/2817903003
Cr-Commit-Position: refs/heads/master@{#464385}
Committed: https://chromium.googlesource.com/chromium/src/+/953df62875eb8a3d485f02ccadce54b27e5cf4d4

[jkrcal, 2017-04-13 11:19:20]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 11:19:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkrcal, 2017-04-13 11:20:03]

jkrcal@chromium.org changed reviewers:
+ treib@chromium.org

[jkrcal, 2017-04-13 11:20:03]

Marc, could you PTAL?
(this is kind of urgent, the bug breaks FRE, again)

[Marc Treib, 2017-04-13 11:38:03]

LGTM since it's urgent, but this feels a bit like a hack. E.g. it could mess up
metrics somewhat, and maybe have other side effects. Maybe add a TODO to
implement this in a cleaner way?

[jkrcal, 2017-04-13 11:49:53]

Thanks! I added the TODO.

[jkrcal, 2017-04-13 11:50:00]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 11:50:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tschumann, 2017-04-13 12:13:35]

On 2017/04/13 11:49:53, jkrcal wrote:
> Thanks! I added the TODO.
lgtm

One way to do this cleaner (follow-up CL is totally fine) would be to use
OnSuggestionsCleared().
We might consider renaming that method though.

[tschumann, 2017-04-13 12:13:48]

On 2017/04/13 12:13:35, tschumann wrote:
> On 2017/04/13 11:49:53, jkrcal wrote:
> > Thanks! I added the TODO.
> lgtm
> 
> One way to do this cleaner (follow-up CL is totally fine) would be to use
> OnSuggestionsCleared().
> We might consider renaming that method though.

[commit-bot: I haz the power, 2017-04-13 12:36:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 12:36:18]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2017-04-13 12:43:42]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2017-04-13 12:43:42]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2817903003/#ps20001
(title: "Marc's comment")

[commit-bot: I haz the power, 2017-04-13 12:43:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 12:47:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492087422515100,
"parent_rev": "699b308b719fd7a1065c05638ce4d635dc7b41ac", "commit_rev":
"953df62875eb8a3d485f02ccadce54b27e5cf4d4"}

[commit-bot: I haz the power, 2017-04-13 12:48:28]

Description was changed from

==========
[Remote scheduler] Make sure we fetch after EULA accepted

Previously, accepting EULA issued a browser-foregrounded trigger. This
trigger is now ignored on default in release channels.

This CL changes it to persistent fetch trigger so that we are sure the
initial fetch is performed, no matter how we change the params in the
future.

BUG=676662
==========

to

==========
[Remote scheduler] Make sure we fetch after EULA accepted

Previously, accepting EULA issued a browser-foregrounded trigger. This
trigger is now ignored on default in release channels.

This CL changes it to persistent fetch trigger so that we are sure the
initial fetch is performed, no matter how we change the params in the
future.

BUG=676662

Review-Url: https://codereview.chromium.org/2817903003
Cr-Commit-Position: refs/heads/master@{#464385}
Committed:
https://chromium.googlesource.com/chromium/src/+/953df62875eb8a3d485f02ccadce...
==========

[commit-bot: I haz the power, 2017-04-13 12:48:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/953df62875eb8a3d485f02ccadce...