Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2817833002: Replacing ScaleToEnclosedRect with ScaleToEnclosingRect (Closed)

Created:
3 years, 8 months ago by malaykeshav
Modified:
3 years, 7 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replacing ScaleToEnclosedRect with ScaleToEnclosingRect Due to the use of ScaleToEnclosedRect, there is a 1px line present in fractional scale factors with certain browser size. Missed this in my original change https://codereview.chromium.org/2673813002 BUG=711112 COMPONENT=SurfaceLayerImpl, CC, Clipping CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2817833002 Cr-Commit-Position: refs/heads/master@{#470635} Committed: https://chromium.googlesource.com/chromium/src/+/cf4bac9c57a560d4502295194eed12a1df04ccce

Patch Set 1 #

Patch Set 2 : Modified unit test to add test case that would fail without this patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M cc/layers/surface_layer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/surface_layer_impl_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
malaykeshav
PTAL
3 years, 8 months ago (2017-04-13 16:24:02 UTC) #7
danakj
Please write a unit test demonstating the bug that would fail without the patch
3 years, 8 months ago (2017-04-13 23:13:13 UTC) #8
malaykeshav
PTAL Updated unit tests
3 years, 7 months ago (2017-05-10 09:16:53 UTC) #16
danakj
Thanks, LGTM
3 years, 7 months ago (2017-05-10 14:27:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817833002/40001
3 years, 7 months ago (2017-05-10 17:38:05 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 17:46:03 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf4bac9c57a560d4502295194eed...

Powered by Google App Engine
This is Rietveld 408576698