Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: chrome/browser/ui/views/ime_driver/remote_text_input_client.cc

Issue 2817783004: Simplify the construction of RemoteTextInputClient (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/ime_driver/remote_text_input_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Reduce number of log messages by logging each NOTIMPLEMENTED() only once. 5 // Reduce number of log messages by logging each NOTIMPLEMENTED() only once.
6 // This has to be before any other includes, else default is picked up. 6 // This has to be before any other includes, else default is picked up.
7 // See base/logging.h for details on this. 7 // See base/logging.h for details on this.
8 #define NOTIMPLEMENTED_POLICY 5 8 #define NOTIMPLEMENTED_POLICY 5
9 9
10 #include "chrome/browser/ui/views/ime_driver/remote_text_input_client.h" 10 #include "chrome/browser/ui/views/ime_driver/remote_text_input_client.h"
11 11
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 13
14 RemoteTextInputClient::RemoteTextInputClient( 14 RemoteTextInputClient::RemoteTextInputClient(
15 ui::mojom::TextInputClientPtr remote_client, 15 ui::mojom::StartSessionDetailsPtr details)
16 ui::TextInputType text_input_type, 16 : remote_client_(std::move(details->client)),
17 ui::TextInputMode text_input_mode, 17 text_input_type_(details->text_input_type),
18 base::i18n::TextDirection text_direction, 18 text_input_mode_(details->text_input_mode),
19 int text_input_flags, 19 text_direction_(details->text_direction),
20 gfx::Rect caret_bounds) 20 text_input_flags_(details->text_input_flags),
21 : remote_client_(std::move(remote_client)), 21 caret_bounds_(details->caret_bounds) {}
22 text_input_type_(text_input_type),
23 text_input_mode_(text_input_mode),
24 text_direction_(text_direction),
25 text_input_flags_(text_input_flags),
26 caret_bounds_(caret_bounds) {}
27 22
28 RemoteTextInputClient::~RemoteTextInputClient() {} 23 RemoteTextInputClient::~RemoteTextInputClient() {}
29 24
30 void RemoteTextInputClient::SetTextInputType( 25 void RemoteTextInputClient::SetTextInputType(
31 ui::TextInputType text_input_type) { 26 ui::TextInputType text_input_type) {
32 text_input_type_ = text_input_type; 27 text_input_type_ = text_input_type;
33 } 28 }
34 29
35 void RemoteTextInputClient::SetCaretBounds(const gfx::Rect& caret_bounds) { 30 void RemoteTextInputClient::SetCaretBounds(const gfx::Rect& caret_bounds) {
36 caret_bounds_ = caret_bounds; 31 caret_bounds_ = caret_bounds;
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 // TODO(moshayedi): crbug.com/631527. 158 // TODO(moshayedi): crbug.com/631527.
164 NOTIMPLEMENTED(); 159 NOTIMPLEMENTED();
165 return false; 160 return false;
166 } 161 }
167 162
168 void RemoteTextInputClient::SetTextEditCommandForNextKeyEvent( 163 void RemoteTextInputClient::SetTextEditCommandForNextKeyEvent(
169 ui::TextEditCommand command) { 164 ui::TextEditCommand command) {
170 // TODO(moshayedi): crbug.com/631527. 165 // TODO(moshayedi): crbug.com/631527.
171 NOTIMPLEMENTED(); 166 NOTIMPLEMENTED();
172 } 167 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/ime_driver/remote_text_input_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698