Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2817743002: Sync confirmation: Enter on paper-checkbox shouldn't confirm dialog (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync confirmation: Enter on paper-checkbox shouldn't confirm dialog R=tommycli@chromium.org BUG=709372 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817743002 Cr-Commit-Position: refs/heads/master@{#464109} Committed: https://chromium.googlesource.com/chromium/src/+/4ea6afa33f38f87ee84a894fb667b29784b031fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Dan Beam
3 years, 8 months ago (2017-04-12 17:44:33 UTC) #2
tommycli
lgtm
3 years, 8 months ago (2017-04-12 17:45:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817743002/1
3 years, 8 months ago (2017-04-12 17:45:43 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 20:57:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ea6afa33f38f87ee84a894fb667...

Powered by Google App Engine
This is Rietveld 408576698