3 years, 8 months ago
(2017-04-12 16:58:30 UTC)
#4
lgtm
commit-bot: I haz the power
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1492015147938470, "parent_rev": "e9c64a91ffa876438944769b5921d171b5390cc8", "commit_rev": "d02c080f54d8aca7e1827374177c17f4ad68a593"}
3 years, 8 months ago
(2017-04-12 17:04:44 UTC)
#5
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492015147938470, "parent_rev":
"e9c64a91ffa876438944769b5921d171b5390cc8", "commit_rev":
"d02c080f54d8aca7e1827374177c17f4ad68a593"}
commit-bot: I haz the power
Description was changed from ========== Revert of Reimplement AccountManagerHelper singleton instance creation (patchset #4 id:180001 ...
3 years, 8 months ago
(2017-04-12 17:05:36 UTC)
#6
Message was sent while issue was closed.
Description was changed from
==========
Revert of Reimplement AccountManagerHelper singleton instance creation (patchset
#4 id:180001 of https://codereview.chromium.org/2747293005/ )
Reason for revert:
Caused multiple bot failures, see crbug.com/710901.
Original issue's description:
> Reimplement AccountManagerHelper singleton instance creation
>
> Current implementation of AccountManagerHelper can instantiate wrong delegate
> type if get() is called in too early. This CL fixes it. AtomicReference is
used
> to avoid relying on external synchronization, because get() can be called
> from different threads. This CL also adds
> AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
> there's no interference between tests.
>
> BUG=698258
>
> Review-Url: https://codereview.chromium.org/2747293005
> Cr-Commit-Position: refs/heads/master@{#463963}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1305003fecaca059c4e3a5678eb4...TBR=rogerta@chromium.org,nyquist@chromium.org,bsazonov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698258
==========
to
==========
Revert of Reimplement AccountManagerHelper singleton instance creation (patchset
#4 id:180001 of https://codereview.chromium.org/2747293005/ )
Reason for revert:
Caused multiple bot failures, see crbug.com/710901.
Original issue's description:
> Reimplement AccountManagerHelper singleton instance creation
>
> Current implementation of AccountManagerHelper can instantiate wrong delegate
> type if get() is called in too early. This CL fixes it. AtomicReference is
used
> to avoid relying on external synchronization, because get() can be called
> from different threads. This CL also adds
> AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
> there's no interference between tests.
>
> BUG=698258
>
> Review-Url: https://codereview.chromium.org/2747293005
> Cr-Commit-Position: refs/heads/master@{#463963}
> Committed:
https://chromium.googlesource.com/chromium/src/+/1305003fecaca059c4e3a5678eb4...TBR=rogerta@chromium.org,nyquist@chromium.org,bsazonov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698258
Review-Url: https://codereview.chromium.org/2817723002
Cr-Commit-Position: refs/heads/master@{#464058}
Committed:
https://chromium.googlesource.com/chromium/src/+/d02c080f54d8aca7e1827374177c...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d02c080f54d8aca7e1827374177c17f4ad68a593
3 years, 8 months ago
(2017-04-12 17:05:37 UTC)
#7
Issue 2817723002: Revert of Reimplement AccountManagerHelper singleton instance creation
(Closed)
Created 3 years, 8 months ago by Donn Denman
Modified 3 years, 8 months ago
Reviewers: Roger Tawa OOO till Jul 10th, nyquist, bsazonov
Base URL:
Comments: 0