Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2817723002: Revert of Reimplement AccountManagerHelper singleton instance creation (Closed)

Created:
3 years, 8 months ago by Donn Denman
Modified:
3 years, 8 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reimplement AccountManagerHelper singleton instance creation (patchset #4 id:180001 of https://codereview.chromium.org/2747293005/ ) Reason for revert: Caused multiple bot failures, see crbug.com/710901. Original issue's description: > Reimplement AccountManagerHelper singleton instance creation > > Current implementation of AccountManagerHelper can instantiate wrong delegate > type if get() is called in too early. This CL fixes it. AtomicReference is used > to avoid relying on external synchronization, because get() can be called > from different threads. This CL also adds > AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure > there's no interference between tests. > > BUG=698258 > > Review-Url: https://codereview.chromium.org/2747293005 > Cr-Commit-Position: refs/heads/master@{#463963} > Committed: https://chromium.googlesource.com/chromium/src/+/1305003fecaca059c4e3a5678eb48f0a00a46317 TBR=rogerta@chromium.org,nyquist@chromium.org,bsazonov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=698258 Review-Url: https://codereview.chromium.org/2817723002 Cr-Commit-Position: refs/heads/master@{#464058} Committed: https://chromium.googlesource.com/chromium/src/+/d02c080f54d8aca7e1827374177c17f4ad68a593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -125 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceTest.java View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninHelperTest.java View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninTest.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/util/FeatureUtilitiesTest.java View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java View 4 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/signin/SigninTestUtil.java View 1 chunk +0 lines, -8 lines 0 comments Download
M components/signin/core/browser/account_tracker_service_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java View 4 chunks +25 lines, -27 lines 0 comments Download
M components/signin/core/browser/android/java/src/org/chromium/components/signin/ChildAccountInfoFetcher.java View 1 chunk +0 lines, -7 lines 0 comments Download
M components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/AccountManagerHelperTest.java View 1 chunk +0 lines, -6 lines 0 comments Download
M components/signin/core/browser/child_account_info_fetcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/signin/core/browser/child_account_info_fetcher.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/signin/core/browser/child_account_info_fetcher_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/signin/core/browser/child_account_info_fetcher_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Donn Denman
Created Revert of Reimplement AccountManagerHelper singleton instance creation
3 years, 8 months ago (2017-04-12 16:39:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817723002/1
3 years, 8 months ago (2017-04-12 16:39:49 UTC) #3
nyquist
lgtm
3 years, 8 months ago (2017-04-12 16:58:30 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 17:05:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d02c080f54d8aca7e1827374177c...

Powered by Google App Engine
This is Rietveld 408576698